add fallback for fullLayout_plots :

etpinard · etpinard · commit 5a83c8431b23 · 2016-05-26T15:02:01.000-04:00
- so that Plots.getSubplots('gl2d' or 'cartesian') does not fail
  on a blank (i.e. Plotly.plot(gd, [])) plot
- I am beginning to doubt that storing both 'cartesian' and 'gl2d'
  subplot objects in fullLayout._plots is the way to go.
diff --git a/src/plots/plots.js b/src/plots/plots.js
@@ -193,7 +193,7 @@ plots.getSubplotIds = function getSubplotIds(layout, type) {
     if(type === 'cartesian' && (!layout._has || !layout._has('cartesian'))) return [];
     if(type === 'gl2d' && (!layout._has || !layout._has('gl2d'))) return [];
     if(type === 'cartesian' || type === 'gl2d') {
-        return Object.keys(layout._plots);
+        return Object.keys(layout._plots || {});
     }
 
     var idRegex = _module.idRegex,

Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,7 @@ plots.getSubplotIds = function getSubplotIds(layout, type) {`
`193`	`193`	`if(type === 'cartesian' && (!layout._has \|\| !layout._has('cartesian'))) return [];`
`194`	`194`	`if(type === 'gl2d' && (!layout._has \|\| !layout._has('gl2d'))) return [];`
`195`	`195`	`if(type === 'cartesian' \|\| type === 'gl2d') {`
`196`		`- return Object.keys(layout._plots);`
	`196`	`+ return Object.keys(layout._plots \|\| {});`
`197`	`197`	`}`
`198`	`198`
`199`	`199`	`var idRegex = _module.idRegex,`