Skip to content

Commit 4efe6a9

Browse files
committed
PR feedback: pruning in-progress comments
1 parent 523f61b commit 4efe6a9

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

src/transforms/groupby.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,6 @@ function transformOne(trace, state, attributeSet) {
131131
var arrayAttributes = attributeSet
132132
.filter(function(array) {return Array.isArray(Lib.nestedProperty(trace, array).get());});
133133

134-
// fixme the O(n**3) complexity
135134
for(var i = 0; i < groupNames.length; i++) {
136135
var groupName = groupNames[i];
137136

test/jasmine/tests/transform_groupby_test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ describe('groupby', function() {
288288
expect(gd.data[0].x).toEqual([1, -1, -2, 0, 1, 2, 3]);
289289
expect(gd.data[0].y).toEqual([1, 2, 3, 1, 2, 3, 1]);
290290

291-
expect(gd._fullData.length).toEqual(1); // fixme not: good, okay it's 1 here (one implied group / thing)
291+
expect(gd._fullData.length).toEqual(1);
292292
expect(gd._fullData[0].x).toEqual([ 1, -1, -2, 0, 1, 2, 3 ]);
293293
expect(gd._fullData[0].y).toEqual([1, 2, 3, 1, 2, 3, 1]);
294294

0 commit comments

Comments
 (0)