Skip to content

Commit 4a91a74

Browse files
authored
Merge pull request #6485 from plotly/chrome-v110
Upgrade chrome to fix jasmine tests on CircleCI
2 parents 70c49ce + ac0932a commit 4a91a74

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

.circleci/config.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ jobs:
5656
working_directory: ~/plotly.js
5757
steps:
5858
- browser-tools/install-browser-tools: &browser-versions
59-
chrome-version: 93.0.4577.63
59+
chrome-version: 110.0.5481.100
6060
install-firefox: false
6161
install-geckodriver: false
6262
- attach_workspace:
@@ -93,7 +93,7 @@ jobs:
9393
working_directory: ~/plotly.js
9494
steps:
9595
- browser-tools/install-browser-tools: &browser-versions
96-
chrome-version: 93.0.4577.63
96+
chrome-version: 110.0.5481.100
9797
install-firefox: false
9898
install-geckodriver: false
9999
- attach_workspace:
@@ -113,7 +113,7 @@ jobs:
113113
working_directory: ~/plotly.js
114114
steps:
115115
- browser-tools/install-browser-tools: &browser-versions
116-
chrome-version: 93.0.4577.63
116+
chrome-version: 110.0.5481.100
117117
install-firefox: false
118118
install-geckodriver: false
119119
- attach_workspace:
@@ -132,7 +132,7 @@ jobs:
132132
working_directory: ~/plotly.js
133133
steps:
134134
- browser-tools/install-browser-tools: &browser-versions
135-
chrome-version: 93.0.4577.63
135+
chrome-version: 110.0.5481.100
136136
install-firefox: false
137137
install-geckodriver: false
138138
- attach_workspace:
@@ -151,7 +151,7 @@ jobs:
151151
working_directory: ~/plotly.js
152152
steps:
153153
- browser-tools/install-browser-tools: &browser-versions
154-
chrome-version: 93.0.4577.63
154+
chrome-version: 110.0.5481.100
155155
install-firefox: false
156156
install-geckodriver: false
157157
- attach_workspace:

test/jasmine/tests/geo_test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2759,10 +2759,10 @@ describe('Test geo interactions update marker angles:', function() {
27592759
})
27602760
.then(function() {
27612761
newPath = getPath();
2762-
expect(newPath).toEqual('M0,0L18.238949513733473,8.206139204003389L19.579067718529352,-4.081679467234269Z');
2762+
expect(newPath).toEqual('M0,0L18.238949470790537,8.206139299448276L19.579067739888885,-4.081679364776507Z');
27632763

27642764
expect(newPath).not.toEqual(initialPath);
2765-
expect(newPath).toEqual('M0,0L18.238949513733473,8.206139204003389L19.579067718529352,-4.081679467234269Z');
2765+
expect(newPath).toEqual('M0,0L18.238949470790537,8.206139299448276L19.579067739888885,-4.081679364776507Z');
27662766
expect(initialPath).toEqual('M0,0L-1.5033314641545745,19.94341982983066L10.506227353572104,17.01820163222463Z');
27672767
})
27682768
.then(done, done.fail);

test/jasmine/tests/sankey_test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -771,7 +771,7 @@ describe('sankey tests', function() {
771771
.then(done, done.fail);
772772
});
773773

774-
it('should position hover labels correctly', function(done) {
774+
it('@noCI should position hover labels correctly', function(done) {
775775
var gd = createGraphDiv();
776776
var mockCopy = Lib.extendDeep({}, mock);
777777

test/jasmine/tests/select_test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2277,7 +2277,7 @@ describe('Test select box and lasso per trace:', function() {
22772277
});
22782278

22792279
[false, true].forEach(function(hasCssTransform) {
2280-
it('should work for waterfall traces, hasCssTransform: ' + hasCssTransform, function(done) {
2280+
it('@noCI should work for waterfall traces, hasCssTransform: ' + hasCssTransform, function(done) {
22812281
var assertPoints = makeAssertPoints(['curveNumber', 'x', 'y']);
22822282
var assertSelectedPoints = makeAssertSelectedPoints();
22832283
var assertRanges = makeAssertRanges();
@@ -2338,7 +2338,7 @@ describe('Test select box and lasso per trace:', function() {
23382338
});
23392339

23402340
[false, true].forEach(function(hasCssTransform) {
2341-
it('should work for funnel traces, hasCssTransform: ' + hasCssTransform, function(done) {
2341+
it('@noCI should work for funnel traces, hasCssTransform: ' + hasCssTransform, function(done) {
23422342
var assertPoints = makeAssertPoints(['curveNumber', 'x', 'y']);
23432343
var assertSelectedPoints = makeAssertSelectedPoints();
23442344
var assertRanges = makeAssertRanges();
@@ -2492,7 +2492,7 @@ describe('Test select box and lasso per trace:', function() {
24922492
});
24932493

24942494
[false, true].forEach(function(hasCssTransform) {
2495-
it('should work for date/category traces, hasCssTransform: ' + hasCssTransform, function(done) {
2495+
it('@noCI should work for date/category traces, hasCssTransform: ' + hasCssTransform, function(done) {
24962496
var assertPoints = makeAssertPoints(['curveNumber', 'x', 'y']);
24972497
var assertSelectedPoints = makeAssertSelectedPoints();
24982498

0 commit comments

Comments
 (0)