Skip to content

Commit 3d2bf32

Browse files
committed
minor cleanup of model and viewModel
1 parent d83547b commit 3d2bf32

File tree

1 file changed

+9
-14
lines changed

1 file changed

+9
-14
lines changed

src/traces/parcoords/parcoords.js

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,8 @@ function integerScale(integerPadding, dimension) {
9191

9292
function model(layout, d, i) {
9393

94-
var data = d.dimensions;
95-
9694
var canvasPixelRatio = d.lines.pixelratio;
95+
9796
var lines = Lib.extendDeep(d.lines, {
9897
color: d.line.color.map(domainToUnitScale({values: d.line.color})),
9998
canvasOverdrag: overdrag * canvasPixelRatio
@@ -103,25 +102,20 @@ function model(layout, d, i) {
103102
var layoutHeight = layout.height * (d.domain.y[1] - d.domain.y[0]);
104103

105104
var padding = d.padding || 80;
106-
var translateX = (d.domain.x[0] || 0) * layout.width;
107-
var translateY = (d.domain.y[0] || 0) * layout.height;
108105
var width = layoutWidth - 2 * padding - legendWidth; // leavig room for the colorbar
109106
var height = layoutHeight - 2 * padding;
110107

111-
var canvasWidth = width * canvasPixelRatio + 2 * lines.canvasOverdrag;
112-
var canvasHeight = height * canvasPixelRatio;
113-
114108
return {
115109
key: i,
116-
dimensions: data,
110+
dimensions: d.dimensions,
117111
tickDistance: d.tickdistance,
118112
unitToColor: d.unitToColor,
119113
lines: lines,
120-
translateX: translateX,
121-
translateY: translateY,
114+
translateX: (d.domain.x[0] || 0) * layout.width,
115+
translateY: (d.domain.y[0] || 0) * layout.height,
122116
padding: padding,
123-
canvasWidth: canvasWidth,
124-
canvasHeight: canvasHeight,
117+
canvasWidth: width * canvasPixelRatio + 2 * lines.canvasOverdrag,
118+
canvasHeight: height * canvasPixelRatio,
125119
width: width,
126120
height: height,
127121
canvasPixelRatio: canvasPixelRatio
@@ -133,9 +127,10 @@ function viewModel(model) {
133127
var lines = model.lines;
134128
var width = model.width;
135129
var height = model.height;
130+
var dimensions = model.dimensions;
136131
var canvasPixelRatio = model.canvasPixelRatio;
137132

138-
var xScale = d3.scale.ordinal().domain(d3.range(model.dimensions.filter(visible).length)).rangePoints([0, width], 0);
133+
var xScale = d3.scale.ordinal().domain(d3.range(dimensions.filter(visible).length)).rangePoints([0, width], 0);
139134

140135
var unitPad = lines.verticalpadding / (height * canvasPixelRatio);
141136
var unitPadScale = (1 - 2 * unitPad);
@@ -147,7 +142,7 @@ function viewModel(model) {
147142
model: model
148143
};
149144

150-
viewModel.panels = model.dimensions.filter(visible).map(function(dimension, i) {
145+
viewModel.panels = dimensions.filter(visible).map(function(dimension, i) {
151146
var domainToUnit = domainToUnitScale(dimension);
152147
return {
153148
key: dimension.id || dimension.label,

0 commit comments

Comments
 (0)