Skip to content

Commit 3a6b49c

Browse files
committed
require scatter components directly into jasmine test file
1 parent 6757bee commit 3a6b49c

File tree

1 file changed

+16
-15
lines changed

1 file changed

+16
-15
lines changed

test/jasmine/tests/scatter_test.js

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
var Plotly = require('@src/plotly');
1+
var Scatter = require('@src/traces/scatter');
2+
var makeBubbleSizeFn = require('@src/traces/scatter/make_bubble_size_func');
3+
var linePoints = require('@src/traces/scatter/line_points');
4+
var Lib = require('@src/lib');
25

36
describe('Test scatter', function() {
47
'use strict';
@@ -10,7 +13,7 @@ describe('Test scatter', function() {
1013
var defaultColor = '#444',
1114
layout = {};
1215

13-
var supplyDefaults = Plotly.Scatter.supplyDefaults;
16+
var supplyDefaults = Scatter.supplyDefaults;
1417

1518
beforeEach(function() {
1619
traceOut = {};
@@ -66,7 +69,7 @@ describe('Test scatter', function() {
6669
size: [1, 4, 2, 10]
6770
}
6871
},
69-
isBubble = Plotly.Scatter.isBubble(trace);
72+
isBubble = Scatter.isBubble(trace);
7073

7174
expect(isBubble).toBe(true);
7275
});
@@ -77,7 +80,7 @@ describe('Test scatter', function() {
7780
size: 10
7881
}
7982
},
80-
isBubble = Plotly.Scatter.isBubble(trace);
83+
isBubble = Scatter.isBubble(trace);
8184

8285
expect(isBubble).toBe(false);
8386
});
@@ -88,7 +91,7 @@ describe('Test scatter', function() {
8891
color: 'red'
8992
}
9093
},
91-
isBubble = Plotly.Scatter.isBubble(trace);
94+
isBubble = Scatter.isBubble(trace);
9295

9396
expect(isBubble).toBe(false);
9497
});
@@ -99,16 +102,15 @@ describe('Test scatter', function() {
99102
color: 'red'
100103
}
101104
},
102-
isBubble = Plotly.Scatter.isBubble(trace);
105+
isBubble = Scatter.isBubble(trace);
103106

104107
expect(isBubble).toBe(false);
105108
});
106109

107110
});
108111

109-
describe('getBubbleSizeFn', function() {
110-
var getBubbleSizeFn = Plotly.Scatter.getBubbleSizeFn,
111-
markerSizes = [
112+
describe('makeBubbleSizeFn', function() {
113+
var markerSizes = [
112114
0, '1', 2.21321321, 'not-a-number',
113115
100, 1000.213213, 1e7, undefined, null, -100
114116
],
@@ -118,7 +120,7 @@ describe('Test scatter', function() {
118120

119121
it('should scale w.r.t. bubble diameter when sizemode=diameter', function() {
120122
trace.marker.sizemode = 'diameter';
121-
sizeFn = getBubbleSizeFn(trace);
123+
sizeFn = makeBubbleSizeFn(trace);
122124

123125
expected = [
124126
0, 0.5, 1.106606605, 0, 50, 500.1066065, 5000000, 0, 0, 0
@@ -128,7 +130,7 @@ describe('Test scatter', function() {
128130

129131
it('should scale w.r.t. bubble area when sizemode=area', function() {
130132
trace.marker.sizemode = 'area';
131-
sizeFn = getBubbleSizeFn(trace);
133+
sizeFn = makeBubbleSizeFn(trace);
132134

133135
expected = [
134136
0, 0.7071067811865476, 1.051953708582274, 0, 7.0710678118654755,
@@ -140,7 +142,7 @@ describe('Test scatter', function() {
140142
it('should adjust scaling according to sizeref', function() {
141143
trace.marker.sizemode = 'diameter';
142144
trace.marker.sizeref = 0.1;
143-
sizeFn = getBubbleSizeFn(trace);
145+
sizeFn = makeBubbleSizeFn(trace);
144146

145147
expected = [
146148
0, 5, 11.06606605, 0, 500, 5001.066065, 50000000, 0, 0, 0
@@ -152,7 +154,7 @@ describe('Test scatter', function() {
152154
trace.marker.sizemode = 'diameter';
153155
trace.marker.sizeref = 10;
154156
trace.marker.sizemin = 5;
155-
sizeFn = getBubbleSizeFn(trace);
157+
sizeFn = makeBubbleSizeFn(trace);
156158

157159
expected = [
158160
0, 5, 5, 0, 5, 50.01066065, 500000, 0, 0, 0
@@ -163,8 +165,7 @@ describe('Test scatter', function() {
163165

164166
describe('linePoints', function() {
165167
// test axes are unit-scaled and 100 units long
166-
var ax = {_length: 100, c2p: Plotly.Lib.identity},
167-
linePoints = Plotly.Scatter.linePoints,
168+
var ax = {_length: 100, c2p: Lib.identity},
168169
baseOpts = {
169170
xaxis: ax,
170171
yaxis: ax,

0 commit comments

Comments
 (0)