Skip to content

Commit 363d5ec

Browse files
committed
Refactor the caching for tester DOM into the makeTester function of drawing module
1 parent 29efec0 commit 363d5ec

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

src/components/drawing/index.js

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -496,6 +496,9 @@ drawing.makeTester = function(gd) {
496496

497497
gd._tester = tester;
498498
gd._testref = testref;
499+
500+
drawing.tester = tester.node();
501+
drawing.refRect = testref.node().getBoundingClientRect();
499502
};
500503

501504
// use our offscreen tester to get a clientRect for an element,
@@ -513,11 +516,6 @@ drawing.bBox = function(node) {
513516
return Lib.extendFlat({}, savedBBoxes[saveNum.value]);
514517
}
515518

516-
if(!drawing.test3) {
517-
drawing.test3 = d3.select('#js-plotly-tester');
518-
drawing.tester = drawing.test3.node();
519-
}
520-
521519
// copy the node to test into the tester
522520
var testNode = node.cloneNode(true);
523521
drawing.tester.appendChild(testNode);
@@ -529,10 +527,6 @@ drawing.bBox = function(node) {
529527
});
530528

531529
var testRect = testNode.getBoundingClientRect();
532-
if(!drawing.refRect) {
533-
drawing.refRect = drawing.test3.select('.js-reference-point')
534-
.node().getBoundingClientRect();
535-
}
536530

537531
drawing.tester.removeChild(testNode);
538532

0 commit comments

Comments
 (0)