Skip to content

Commit 2445406

Browse files
committed
Fix staticPlot behaviour for range slider and legend
These changes ensure that when `staticPlot` is active: 1. Items inside a legend cannot be toggled 2. The range slider cannot be interacted with, and the grab handles for adjusting the slider box are hidden. Fixes #5177
1 parent 4d821e3 commit 2445406

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/components/legend/draw.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -460,6 +460,8 @@ function ensureLength(str, maxLength) {
460460
}
461461

462462
function setupTraceToggle(g, gd) {
463+
if(gd._context.staticPlot) return;
464+
463465
var doubleClickDelay = gd._context.doubleClickDelay;
464466
var newMouseDownTime;
465467
var numClicks = 1;

src/components/rangeslider/draw.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,8 @@ module.exports = function(gd) {
232232
};
233233

234234
function setupDragElement(rangeSlider, gd, axisOpts, opts) {
235+
if(gd._context.staticPlot) return;
236+
235237
var slideBox = rangeSlider.select('rect.' + constants.slideBoxClassName).node();
236238
var grabAreaMin = rangeSlider.select('rect.' + constants.grabAreaMinClassName).node();
237239
var grabAreaMax = rangeSlider.select('rect.' + constants.grabAreaMaxClassName).node();
@@ -590,6 +592,8 @@ function drawSlideBox(rangeSlider, gd, axisOpts, opts) {
590592
}
591593

592594
function drawGrabbers(rangeSlider, gd, axisOpts, opts) {
595+
if(gd._context.staticPlot) return;
596+
593597
// <g grabber />
594598
var grabberMin = Lib.ensureSingle(rangeSlider, 'g', constants.grabberMinClassName);
595599
var grabberMax = Lib.ensureSingle(rangeSlider, 'g', constants.grabberMaxClassName);
@@ -619,8 +623,6 @@ function drawGrabbers(rangeSlider, gd, axisOpts, opts) {
619623
handleMax.attr(handleDynamicAttrs);
620624

621625
// <g grabarea />
622-
if(gd._context.staticPlot) return;
623-
624626
var grabAreaFixAttrs = {
625627
width: constants.grabAreaWidth,
626628
x: 0,

0 commit comments

Comments
 (0)