Skip to content

Commit 183b734

Browse files
committed
set miter-limit to 2 + 🔒 in polar_bar-overlay mock
1 parent 6494302 commit 183b734

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

src/traces/barpolar/plot.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ module.exports = function plot(gd, subplot, cdbar) {
3535
var bars = pointGroup.selectAll('g.point').data(Lib.identity);
3636

3737
bars.enter().append('g')
38+
.style('vector-effect', 'non-scaling-stroke')
39+
.style('stroke-miterlimit', 2)
3840
.classed('point', true);
3941

4042
bars.exit().remove();
@@ -82,9 +84,7 @@ module.exports = function plot(gd, subplot, cdbar) {
8284
dPath = pathFn(rp0, rp1, thetag0, thetag1);
8385
}
8486

85-
Lib.ensureSingle(bar, 'path')
86-
.style('vector-effect', 'non-scaling-stroke')
87-
.attr('d', dPath);
87+
Lib.ensureSingle(bar, 'path').attr('d', dPath);
8888
});
8989

9090
// clip plotGroup, when trace layer isn't clipped
3 KB
Loading

test/image/mocks/polar_bar-overlay.json

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,15 @@
66
"opacity": 0.7
77
}, {
88
"type": "barpolar",
9-
"r": [1, 2, 3],
10-
"theta": [180, 90, 360],
11-
"opacity": 0.7
9+
"r": [3, 3],
10+
"theta": [0, 45],
11+
"opacity": 0.7,
12+
"marker": {
13+
"line": {"width": 5}
14+
}
1215
}],
1316
"layout": {
14-
"polar": {"barmode": "overlay" },
17+
"polar": {"barmode": "overlay"},
1518
"width": 500,
1619
"height": 500
1720
}

0 commit comments

Comments
 (0)