Skip to content

Commit 14e537d

Browse files
committed
#581 adding back preexisting defaulting mechanisms to pass preexisting test cases
1 parent 8240de2 commit 14e537d

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/traces/scatter/line_defaults.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,16 @@ var colorscaleDefaults = require('../../components/colorscale/defaults');
1515

1616
// common to 'scatter', 'scatter3d', 'scattergeo' and 'scattergl'
1717
module.exports = function lineDefaults(traceIn, traceOut, defaultColor, layout, coerce) {
18+
1819
var markerColor = (traceIn.marker || {}).color;
1920

20-
if(traceIn.line) defaultColor = markerColor;
21-
22-
coerce('line.color', defaultColor);
2321
if(hasColorscale(traceIn, 'line')) {
2422
colorscaleDefaults(
2523
traceIn, traceOut, layout, coerce, {prefix: 'line.', cLetter: 'c'}
2624
);
25+
} else {
26+
coerce('line.color', (Array.isArray(markerColor) ? false : markerColor) ||
27+
defaultColor);
2728
}
2829

2930

src/traces/scatter/marker_defaults.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ var subTypes = require('./subtypes');
1919
// common to 'scatter', 'scatter3d', 'scattergeo' and 'scattergl'
2020
module.exports = function markerDefaults(traceIn, traceOut, defaultColor, layout, coerce) {
2121
var isBubble = subTypes.isBubble(traceIn),
22-
// TEMPORARILY HOLDING OFF ON THE DEFAULTING
23-
lineColor = ({}).color, // lineColor = (traceIn.line || {}).color,
22+
lineColor = (traceIn.line || {}).color,
2423
defaultMLC;
2524

2625
if(lineColor) defaultColor = lineColor;

0 commit comments

Comments
 (0)