Skip to content

Commit 0c901b5

Browse files
committed
fixup i === j subplot logic and baselines
1 parent 7f916b0 commit 0c901b5

File tree

4 files changed

+2
-4
lines changed

4 files changed

+2
-4
lines changed

src/traces/splom/defaults.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,12 +132,10 @@ function handleAxisDefaults(traceIn, traceOut, layout, coerce) {
132132
layout._splomSubplots[id] = 1;
133133
} else if(i < j && showLower) {
134134
layout._splomSubplots[id] = 1;
135-
} else {
135+
} else if(i === j && (showDiag || !showLower || !showUpper)) {
136136
// need to include diagonal subplots when
137137
// hiding one half and the diagonal
138-
if(showDiag || !showLower || !showUpper) {
139-
layout._splomSubplots[id] = 1;
140-
}
138+
layout._splomSubplots[id] = 1;
141139
}
142140
}
143141
}
-1.76 KB
Loading

test/image/baselines/splom_lower.png

-115 Bytes
Loading
-1.83 KB
Loading

0 commit comments

Comments
 (0)