Skip to content

Commit 0a89aaf

Browse files
committed
hidden -> visible
1 parent b27bf96 commit 0a89aaf

File tree

5 files changed

+11
-6
lines changed

5 files changed

+11
-6
lines changed

src/traces/parcoords/attributes.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,11 @@ module.exports = {
7878
role: 'info',
7979
description: 'The shown name of the dimension.'
8080
},
81-
hidden: {
81+
visible: {
8282
valType: 'boolean',
83-
dflt: false,
83+
dflt: true,
8484
role: 'info',
85-
description: 'Hides the dimension when set to true.'
85+
description: 'Shows the dimension when set to `true` (the default). Hides the dimension for `false`.'
8686
},
8787
range: {
8888
valType: 'data_array',

src/traces/parcoords/calc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ module.exports = function calc(gd, trace) {
3737
range: vals[i].range,
3838
constraintrange: vals[i].constraintrange,
3939
integer: vals[i].integer,
40-
hidden: vals[i].hidden,
40+
visible: vals[i].visible,
4141
label: vals[i].label,
4242
values: vals[i].values
4343
});

src/traces/parcoords/defaults.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ function dimensionsDefaults(traceIn, traceOut) {
5050
coerce('id');
5151
coerce('label');
5252
coerce('integer');
53-
coerce('hidden');
53+
coerce('visible');
5454
coerce('range');
5555
coerce('constraintrange');
5656
coerce('values');

src/traces/parcoords/parcoords.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ function keyFun(d) {return d.key;}
1919

2020
function repeat(d) {return [d];}
2121

22-
function visible(dimension) {return !dimension.hidden;}
22+
function visible(dimension) {return !('visible' in dimension) || dimension.visible;}
2323

2424
function dimensionExtent(dimension) {
2525

test/jasmine/tests/parcoords_test.js

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)