Skip to content

Commit 0838d95

Browse files
committed
var->dim
1 parent a1cb5b0 commit 0838d95

File tree

2 files changed

+24
-24
lines changed

2 files changed

+24
-24
lines changed

src/traces/parcoords/lines.js

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -234,14 +234,14 @@ module.exports = function(canvasGL, lines, canvasWidth, canvasHeight, data, unit
234234
resolution: regl.prop('resolution'),
235235
viewBoxPosition: regl.prop('viewBoxPosition'),
236236
viewBoxSize: regl.prop('viewBoxSize'),
237-
var1A: regl.prop('var1A'),
238-
var2A: regl.prop('var2A'),
239-
var1B: regl.prop('var1B'),
240-
var2B: regl.prop('var2B'),
241-
var1C: regl.prop('var1C'),
242-
var2C: regl.prop('var2C'),
243-
var1D: regl.prop('var1D'),
244-
var2D: regl.prop('var2D'),
237+
dim1A: regl.prop('dim1A'),
238+
dim2A: regl.prop('dim2A'),
239+
dim1B: regl.prop('dim1B'),
240+
dim2B: regl.prop('dim2B'),
241+
dim1C: regl.prop('dim1C'),
242+
dim2C: regl.prop('dim2C'),
243+
dim1D: regl.prop('dim1D'),
244+
dim2D: regl.prop('dim2D'),
245245
loA: regl.prop('loA'),
246246
hiA: regl.prop('hiA'),
247247
loB: regl.prop('loB'),
@@ -303,14 +303,14 @@ module.exports = function(canvasGL, lines, canvasWidth, canvasHeight, data, unit
303303
resolution: [canvasWidth, canvasHeight],
304304
viewBoxPosition: [x + overdrag, 0],
305305
viewBoxSize: [panelSizeX, canvasPanelSizeY],
306-
var1A: d3.range(16).map(function(d) {return d === i ? 1 : 0;}),
307-
var2A: d3.range(16).map(function(d) {return d === ii ? 1 : 0;}),
308-
var1B: d3.range(16).map(function(d) {return d + 16 === i ? 1 : 0;}),
309-
var2B: d3.range(16).map(function(d) {return d + 16 === ii ? 1 : 0;}),
310-
var1C: d3.range(16).map(function(d) {return d + 32 === i ? 1 : 0;}),
311-
var2C: d3.range(16).map(function(d) {return d + 32 === ii ? 1 : 0;}),
312-
var1D: d3.range(16).map(function(d) {return d + 48 === i ? 1 : 0;}),
313-
var2D: d3.range(16).map(function(d) {return d + 48 === ii ? 1 : 0;}),
306+
dim1A: d3.range(16).map(function(d) {return d === i ? 1 : 0;}),
307+
dim2A: d3.range(16).map(function(d) {return d === ii ? 1 : 0;}),
308+
dim1B: d3.range(16).map(function(d) {return d + 16 === i ? 1 : 0;}),
309+
dim2B: d3.range(16).map(function(d) {return d + 16 === ii ? 1 : 0;}),
310+
dim1C: d3.range(16).map(function(d) {return d + 32 === i ? 1 : 0;}),
311+
dim2C: d3.range(16).map(function(d) {return d + 32 === ii ? 1 : 0;}),
312+
dim1D: d3.range(16).map(function(d) {return d + 48 === i ? 1 : 0;}),
313+
dim2D: d3.range(16).map(function(d) {return d + 48 === ii ? 1 : 0;}),
314314
loA: d3.range(16).map(function(i) {return paddedUnit((!context && valid(i, 0) ? orig(i).filter[0] : 0)) - filterEpsilon;}),
315315
hiA: d3.range(16).map(function(i) {return paddedUnit((!context && valid(i, 0) ? orig(i).filter[1] : 1)) + filterEpsilon;}),
316316
loB: d3.range(16).map(function(i) {return paddedUnit((!context && valid(i, 16) ? orig(i + 16).filter[0] : 0)) - filterEpsilon;}),
@@ -330,11 +330,11 @@ module.exports = function(canvasGL, lines, canvasWidth, canvasHeight, data, unit
330330
var dimensionView = dimensionViews[I];
331331
var i = dimensionView.originalXIndex;
332332
var x = dimensionView.x * canvasPixelRatio;
333-
var nextVar = dimensionViews[(I + 1) % shownDimensionCount];
334-
var ii = nextVar.originalXIndex;
335-
var panelSizeX = nextVar.x * canvasPixelRatio - x;
336-
if(setChanged || !previousAxisOrder[i] || previousAxisOrder[i][0] !== x || previousAxisOrder[i][1] !== nextVar.x) {
337-
previousAxisOrder[i] = [x, nextVar.x];
333+
var nextDim = dimensionViews[(I + 1) % shownDimensionCount];
334+
var ii = nextDim.originalXIndex;
335+
var panelSizeX = nextDim.x * canvasPixelRatio - x;
336+
if(setChanged || !previousAxisOrder[i] || previousAxisOrder[i][0] !== x || previousAxisOrder[i][1] !== nextDim.x) {
337+
previousAxisOrder[i] = [x, nextDim.x];
338338
var item = makeItem(i, ii, x, panelSizeX, dimensionView.originalXIndex, dimensionView.scatter);
339339
renderState.clearOnly = clearOnly;
340340
renderBlock(regl, glAes, renderState, setChanged ? lines.blocklinecount : sampleCount, sampleCount, item);

src/traces/parcoords/shaders/vertex.glsl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ attribute vec4 p0, p1, p2, p3,
77

88
attribute vec4 pf;
99

10-
uniform mat4 var1A, var2A, var1B, var2B, var1C, var2C, var1D, var2D,
10+
uniform mat4 dim1A, dim2A, dim1B, dim2B, dim1C, dim2C, dim1D, dim2D,
1111
loA, hiA, loB, hiB, loC, hiC, loD, hiD;
1212

1313
uniform vec2 resolution,
@@ -58,8 +58,8 @@ void main() {
5858
mshow(pC, loC, hiC) &&
5959
mshow(pD, loD, hiD));
6060

61-
vec2 yy = show * vec2(val(pA, var2A) + val(pB, var2B) + val(pC, var2C) + val(pD, var2D),
62-
val(pA, var1A) + val(pB, var1B) + val(pC, var1C) + val(pD, var1D));
61+
vec2 yy = show * vec2(val(pA, dim2A) + val(pB, dim2B) + val(pC, dim2C) + val(pD, dim2D),
62+
val(pA, dim1A) + val(pB, dim1B) + val(pC, dim1C) + val(pD, dim1D));
6363

6464
vec2 dimensionToggle = vec2(x, 1.0 - x);
6565

0 commit comments

Comments
 (0)