File tree Expand file tree Collapse file tree 2 files changed +47
-0
lines changed Expand file tree Collapse file tree 2 files changed +47
-0
lines changed Original file line number Diff line number Diff line change @@ -340,6 +340,24 @@ exports.cleanData = function(data, existingData) {
340
340
}
341
341
}
342
342
343
+ // transforms backward compatibility fixes
344
+ if ( Array . isArray ( trace . transforms ) ) {
345
+ var transforms = trace . transforms ;
346
+
347
+ for ( i = 0 ; i < transforms . length ; i ++ ) {
348
+ var transform = transforms [ i ] ;
349
+
350
+ if ( ! Lib . isPlainObject ( transform ) ) continue ;
351
+
352
+ if ( transform . type === 'filter' ) {
353
+ if ( transform . filtersrc ) {
354
+ transform . target = transform . filtersrc ;
355
+ delete transform . filtersrc ;
356
+ }
357
+ }
358
+ }
359
+ }
360
+
343
361
// prune empty containers made before the new nestedProperty
344
362
if ( emptyContainer ( trace , 'line' ) ) delete trace . line ;
345
363
if ( 'marker' in trace ) {
Original file line number Diff line number Diff line change @@ -995,6 +995,35 @@ describe('Test plot api', function() {
995
995
996
996
expect ( gd . data [ 1 ] . contours ) . toBeUndefined ( ) ;
997
997
} ) ;
998
+
999
+ it ( 'should rename *filtersrc* to *target* in filter transforms' , function ( ) {
1000
+ var data = [ {
1001
+ transforms : [ {
1002
+ type : 'filter' ,
1003
+ filtersrc : 'y'
1004
+ } , {
1005
+ type : 'filter' ,
1006
+ operation : '<'
1007
+ } ]
1008
+ } , {
1009
+ transforms : [ {
1010
+ type : 'filter' ,
1011
+ target : 'y'
1012
+ } ]
1013
+ } ] ;
1014
+
1015
+ Plotly . plot ( gd , data ) ;
1016
+
1017
+ var trace0 = gd . data [ 0 ] ,
1018
+ trace1 = gd . data [ 1 ] ;
1019
+
1020
+ expect ( trace0 . transforms . length ) . toEqual ( 2 ) ;
1021
+ expect ( trace0 . transforms [ 0 ] . filtersrc ) . toBeUndefined ( ) ;
1022
+ expect ( trace0 . transforms [ 0 ] . target ) . toEqual ( 'y' ) ;
1023
+
1024
+ expect ( trace1 . transforms . length ) . toEqual ( 1 ) ;
1025
+ expect ( trace1 . transforms [ 0 ] . target ) . toEqual ( 'y' ) ;
1026
+ } ) ;
998
1027
} ) ;
999
1028
1000
1029
describe ( 'Plotly.update should' , function ( ) {
You can’t perform that action at this time.
0 commit comments