Skip to content

Commit 046dd32

Browse files
committed
add backward-compatibility map for *filtersrc*
1 parent 168b447 commit 046dd32

File tree

2 files changed

+47
-0
lines changed

2 files changed

+47
-0
lines changed

src/plot_api/helpers.js

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -340,6 +340,24 @@ exports.cleanData = function(data, existingData) {
340340
}
341341
}
342342

343+
// transforms backward compatibility fixes
344+
if(Array.isArray(trace.transforms)) {
345+
var transforms = trace.transforms;
346+
347+
for(i = 0; i < transforms.length; i++) {
348+
var transform = transforms[i];
349+
350+
if(!Lib.isPlainObject(transform)) continue;
351+
352+
if(transform.type === 'filter') {
353+
if(transform.filtersrc) {
354+
transform.target = transform.filtersrc;
355+
delete transform.filtersrc;
356+
}
357+
}
358+
}
359+
}
360+
343361
// prune empty containers made before the new nestedProperty
344362
if(emptyContainer(trace, 'line')) delete trace.line;
345363
if('marker' in trace) {

test/jasmine/tests/plot_api_test.js

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -995,6 +995,35 @@ describe('Test plot api', function() {
995995

996996
expect(gd.data[1].contours).toBeUndefined();
997997
});
998+
999+
it('should rename *filtersrc* to *target* in filter transforms', function() {
1000+
var data = [{
1001+
transforms: [{
1002+
type: 'filter',
1003+
filtersrc: 'y'
1004+
}, {
1005+
type: 'filter',
1006+
operation: '<'
1007+
}]
1008+
}, {
1009+
transforms: [{
1010+
type: 'filter',
1011+
target: 'y'
1012+
}]
1013+
}];
1014+
1015+
Plotly.plot(gd, data);
1016+
1017+
var trace0 = gd.data[0],
1018+
trace1 = gd.data[1];
1019+
1020+
expect(trace0.transforms.length).toEqual(2);
1021+
expect(trace0.transforms[0].filtersrc).toBeUndefined();
1022+
expect(trace0.transforms[0].target).toEqual('y');
1023+
1024+
expect(trace1.transforms.length).toEqual(1);
1025+
expect(trace1.transforms[0].target).toEqual('y');
1026+
});
9981027
});
9991028

10001029
describe('Plotly.update should', function() {

0 commit comments

Comments
 (0)