Skip to content

Commit aa19087

Browse files
committed
merge with master
2 parents 873f476 + aa8c7d7 commit aa19087

File tree

4 files changed

+16
-11
lines changed

4 files changed

+16
-11
lines changed

.travis.yml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,10 @@ addons:
88
packages:
99
- r-base-dev
1010
- r-recommended
11-
- qpdf
1211

1312
env:
1413
global:
15-
- R_LIBS_USER=~/R/library NOT_CRAN=true
14+
- R_LIBS_USER=~/R/library NOT_CRAN=true R_PKG="$(basename $TRAVIS_REPO_SLUG)"
1615
# plotly_api_key (for posting to plot.ly)
1716
- secure: "jlIAFoBGaDWUQDh6oGNb2BgU31/80iioM4y4xwx35yWkGKkNIID1eMEuiIn+/ipLvOVHkPTDS6DYnOtD8EIBpROgAKHFY33gM1h7P6NRxVszzC6WLP2ASnq95DWq36DAC2Oevy05V7nwSRFilPwSt6JLppYUInG+WdaZ+QOSRi4="
1817
# GITHUB_PAT (for pushing to plotly-test-table)
@@ -30,15 +29,17 @@ before_script:
3029
- git clone https://github.com/cpsievert/plotly-test-table.git ../plotly-test-table
3130
- "wget -q -O - https://github.com/yihui/crandalf/raw/master/inst/scripts/install-pandoc | bash"
3231
- Rscript -e 'if (length(find.package("devtools", quiet = TRUE)) == 0L) { install.packages("devtools", repos = "http://cran.rstudio.com") }'
33-
- Rscript -e 'library(devtools);update_packages("devtools", repos = "http://cran.rstudio.com")'
34-
- Rscript -e 'library(devtools);install_deps(repos = "http://cran.rstudio.com", dependencies = TRUE)'
32+
- Rscript -e 'devtools::update_packages("devtools", repos = "http://cran.rstudio.com")'
33+
- Rscript -e 'devtools::install_deps(repos = "http://cran.rstudio.com", dependencies = TRUE)'
34+
- cd ..; rm -f *.tar.gz; R CMD build $R_PKG
35+
- R CMD INSTALL ${R_PKG}_*.tar.gz
3536

3637
script:
3738
# run R CMD check on the non-pull request build
38-
- sh -c "if [ '$TRAVIS_PULL_REQUEST' = 'false' ]; then Rscript -e 'devtools::check()'; fi"
39+
- sh -c "if [ '$TRAVIS_PULL_REQUEST' = 'false' ]; then R CMD check ${R_PKG}_*.tar.gz --no-manual; fi"
3940
# we do some fancy stuff on the pull request build that confuses R CMD check
40-
- sh -c "if [ '$TRAVIS_PULL_REQUEST' != 'false' ]; then Rscript -e 'devtools::install(); source(\"tests/testthat.R\", chdir = T)'; fi"
41+
- sh -c "if [ '$TRAVIS_PULL_REQUEST' != 'false' ]; then Rscript -e 'source(\"plotly/tests/testthat.R\", chdir = T)'; fi"
4142

4243
after_success:
43-
- cd ../plotly-test-table
44+
- cd plotly-test-table
4445
- Rscript ../plotly/inst/build-push-comment.R

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Package: plotly
22
Title: Create Interactive Web Graphics via Plotly's JavaScript Graphing Library
3-
Version: 2.3.1
3+
Version: 2.3.2
44
Authors@R: c(person("Carson", "Sievert", role = c("aut", "cre"),
55
email = "cpsievert1@gmail.com"),
66
person("Chris", "Parmer", role = c("aut", "cph"),

NEWS

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
1-
2.3.1 -- 20 Jan 2015
1+
2.3.2 -- 25 Jan 2015
22

3-
more accurate list of data_array properties. fixes #415
3+
More accurate list of data_array properties. Fixes #415
4+
5+
2.3.1 -- 25 Jan 2015
6+
7+
More accurate conversion of path width. Fixes #373.
48

59
2.3.0 -- 19 Jan 2015
610

R/trace_generation.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -565,7 +565,7 @@ geom2trace <- list(
565565
# when converting ggplot2 size to plotly size, we assume size is an _area_,
566566
# but "size" for lines really means linewidth, so size is a _length_ in this case
567567
# (see aesConverters$size)
568-
params$size <- sqrt(params$size)
568+
params$size <- ifelse(params$size < 1, params$size ^ 2, sqrt(params$size))
569569
list(x=data$x,
570570
y=data$y,
571571
name=params$name,

0 commit comments

Comments
 (0)