add a simple test

Author: cpsievert

R/utils.R

@@ -121,10 +121,10 @@ add_boxed <- function(x) {
     idx <- names(d) %in% get_boxed(d$type %||% "scatter") & sapply(d, length) == 1
     if (any(idx)) x$data[[i]][idx] <- lapply(d[idx], I)
     # (safely) mark individual nested properties
-    d$error_x$array <- i(d$error_x$array)
-    d$error_y$array <- i(d$error_y$array)
-    d$error_x$arrayminus <- i(d$error_x$arrayminus)
-    d$error_y$arrayminus <- i(d$error_y$arrayminus)
+    x$data[[i]]$error_x$array <- i(d$error_x$array)
+    x$data[[i]]$error_y$array <- i(d$error_y$array)
+    x$data[[i]]$error_x$arrayminus <- i(d$error_x$arrayminus)
+    x$data[[i]]$error_y$arrayminus <- i(d$error_y$arrayminus)
   }
   x
 }
@@ -154,22 +154,6 @@ boxers <- list(
 
 i <- function(x) if (is.null(x)) x else I(x)
 
-#' Pick an element from a nested list
-#' @param x a list
-#' @param nms a character vector specifying a search path
-#' @example
-#' x <- list(a = list(b = list(c = "Come and get it!")))
-#' pick(x, c("a", "b", "c"))
-#' #> [1] "Come and get it!"
-pick <- function(x, nms) {
-  for (i in seq_along(nms)) {
-    nm <- nms[i]
-    x <- x[[nm]]
-  }
-  x
-}
-
-
 rm_asis <- function(x) {
   # jsonlite converts NULL to {} and NA to null (plotly prefers null to {})
   # https://github.com/jeroenooms/jsonlite/issues/29

tests/testthat/test-plotly.R

@@ -111,3 +111,12 @@ test_that("inheriting properties works as expected", {
   expect_equal(l$data[[2]]$opacity, 0.5)
   expect_true(all(l$data[[1]]$y > l$data[[2]]$y))
 })
+
+test_that("x/y/z properties have a class of AsIs", {
+  p <- plot_ly(x = 1, y = 1, z = 1, type = "scatter3d")
+  l <- plotly_build(p)
+  tr <- l$data[[1]]
+  expect_true(inherits(tr$x, "AsIs"))
+  expect_true(inherits(tr$y, "AsIs"))
+  expect_true(inherits(tr$z, "AsIs"))
+})