Improve and approve new palmerpenguin visual baselines. Also make sure docker container installs dependencies at run-time

Author: cpsievert

.gitignore

@@ -18,3 +18,4 @@ revdep/
 travis_debug.R
 .httr-oauth
 tests/testthat/Rplots.pdf
+inst/examples/shiny/event_data/tests/shinytest/mytest-current/

inst/docker/Dockerfile.vtest

@@ -95,9 +95,9 @@ RUN R -e "remotes::install_github('r-lib/vdiffr')"
 # install any new dependencies, then either manage cases (the default) or run tests
 # note the workaround to get docker to run a proper exit status when there are testthat errors
 # https://github.com/r-lib/testthat/issues/515#issuecomment-304169376
-CMD R -e "remotes::install_deps(dependencies = TRUE)"
 
-CMD cd /home/plotly; R -e "if (!identical(Sys.getenv('VMODE'), 'ci')) vdiffr::manage_cases(); \
+CMD cd /home/plotly; R -e "remotes::install_deps(dependencies = T); \
+if (!identical(Sys.getenv('VMODE'), 'ci')) vdiffr::manage_cases(); \
   res <- devtools::test(reporter='summary'); \
   df <- as.data.frame(res); \
   if (sum(df\$failed) > 0 || any(df\$error)) q(status=1)"

tests/figs/density2d/density2d.svg

@@ -1,7 +1,7 @@
 context("ggplot themes")
 
 penguin.base <- ggplot(palmerpenguins::penguins) +
-  geom_point(aes(bill_length_mm, bill_length_mm)) +
+  geom_point(aes(bill_length_mm, flipper_length_mm)) +
   theme_grey()
 
 test_that("background translated correctly",{

tests/figs/ggplot-themes/theme-background.svg

@@ -8,11 +8,11 @@ expect_traces <- function(p, n.traces, name){
 }
 
 test_that("plot_ly() handles a simple scatterplot", {
-  p <- plot_ly(palmerpenguins::penguins, x = ~bill_length_mm, y = ~bill_length_mm, color = ~bill_depth_mm)
+  p <- plot_ly(palmerpenguins::penguins, x = ~bill_length_mm, y = ~flipper_length_mm, color = ~bill_depth_mm)
 })
 
 test_that("Mapping a factor variable to color works", {
-  p <- plot_ly(palmerpenguins::penguins, x = ~bill_length_mm, y = ~bill_length_mm, color = ~species)
+  p <- plot_ly(palmerpenguins::penguins, x = ~bill_length_mm, y = ~flipper_length_mm, color = ~species)
   l <- expect_traces(p, 3, "scatterplot-color-factor")
   markers <- lapply(l$data, "[[", "marker")
   cols <- unlist(lapply(markers, "[[", "color"))
@@ -24,15 +24,15 @@ test_that("Custom RColorBrewer pallette works for factor variable", {
   # convert hex to rgba spec for comparison's sake
   colsToCompare <- toRGB(cols)
   # specifying a pallette set should "span the gamut" 
-  p <- plot_ly(palmerpenguins::penguins, x = ~bill_length_mm, y = ~bill_length_mm, color = ~species, 
+  p <- plot_ly(palmerpenguins::penguins, x = ~bill_length_mm, y = ~flipper_length_mm, color = ~species, 
                colors = "Set1")
   l <- expect_traces(p, 3, "scatterplot-color-factor-custom")
   markers <- lapply(l$data, "[[", "marker")
   colz <- unlist(lapply(markers, "[[", "color"))
   idx <- if (packageVersion("scales") > '1.0.0') c(1, 2, 3) else c(1, 5, 9)
   expect_identical(sort(colsToCompare[idx]), sort(colz))
   # providing vector of RGB codes should also work
-  p <- plot_ly(palmerpenguins::penguins, x = ~bill_length_mm, y = ~bill_length_mm, color = ~species, 
+  p <- plot_ly(palmerpenguins::penguins, x = ~bill_length_mm, y = ~flipper_length_mm, color = ~species, 
                colors = cols[1:3])
   l <- expect_traces(p, 3, "scatterplot-color-factor-custom2")
   markers <- lapply(l$data, "[[", "marker")
@@ -51,7 +51,7 @@ test_that("Passing hex codes to colors argument works", {
 })
 
 test_that("Mapping a numeric variable to color works", {
-  p <- plot_ly(palmerpenguins::penguins, x = ~bill_length_mm, y = ~bill_length_mm, color = ~bill_depth_mm)
+  p <- plot_ly(palmerpenguins::penguins, x = ~bill_length_mm, y = ~flipper_length_mm, color = ~bill_depth_mm)
   # one trace is for the colorbar
   l <- expect_traces(p, 2, "scatterplot-color-numeric")
   idx <- vapply(l$data, is.colorbar, logical(1))
@@ -76,7 +76,7 @@ test_that("color/stroke mapping with box translates correctly", {
 })
 
 test_that("Custom RColorBrewer pallette works for numeric variable", {
-  p <- plot_ly(palmerpenguins::penguins, x = ~bill_length_mm, y = ~bill_length_mm, 
+  p <- plot_ly(palmerpenguins::penguins, x = ~bill_length_mm, y = ~flipper_length_mm, 
                color = ~bill_depth_mm, colors = "Greens")
   # one trace is for the colorbar
   l <- expect_traces(p, 2, "scatterplot-color-numeric-custom")

tests/figs/ggplot-themes/theme-panel-border-1.svg

@@ -136,9 +136,7 @@ test_that("subplot accepts a list of plots", {
 
 test_that("ggplotly understands ggmatrix", {
   skip_if_not_installed("GGally")
-  penguins <- palmerpenguins::penguins %>% tidyr::drop_na() %>% 
-    select(species, bill_length_mm, bill_depth_mm, flipper_length_mm, body_mass_g)
-  L <- expect_doppelganger_built(GGally::ggpairs(penguins), 
+  L <- expect_doppelganger_built(GGally::ggpairs(iris), 
                                  "plotly-subplot-ggmatrix")
 })