Merge pull request #1407 from ropensci/retain-opacity-0

cpsievert · web-flow · commit 0acffce3087a · 2018-11-20T11:02:48.000-06:00
Properly retain original opacity of 0
diff --git a/inst/htmlwidgets/plotly.js b/inst/htmlwidgets/plotly.js
@@ -533,7 +533,7 @@ function TraceManager(graphDiv, highlight) {
   // avoid doing this over and over
   this.origOpacity = [];
   for (var i = 0; i < this.origData.length; i++) {
-    this.origOpacity[i] = this.origData[i].opacity || 1;
+    this.origOpacity[i] = this.origData[i].opacity === 0 ? 0 : (this.origData[i].opacity || 1);
   }
 
   // key: group name, value: null or array of keys representing the

Original file line number	Diff line number	Diff line change
`@@ -533,7 +533,7 @@ function TraceManager(graphDiv, highlight) {`
`533`	`533`	`// avoid doing this over and over`
`534`	`534`	`this.origOpacity = [];`
`535`	`535`	`for (var i = 0; i < this.origData.length; i++) {`
`536`		`- this.origOpacity[i] = this.origData[i].opacity \|\| 1;`
	`536`	`+ this.origOpacity[i] = this.origData[i].opacity === 0 ? 0 : (this.origData[i].opacity \|\| 1);`
`537`	`537`	`}`
`538`	`538`
`539`	`539`	`// key: group name, value: null or array of keys representing the`