-
-
Notifications
You must be signed in to change notification settings - Fork 177
Support for resumable uploads #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rough version of rearranged library
Added handler for Resumable.js
Added handler for blueimp File Upload
Clean up handler factories
Added/edited phpDoc
FileCheckHandler supports ng-file-upload
Added support for simple-uploader
Should use getFullFilePath when possible
Updated readme
What the state? Is it implemented? |
I did not have time yesterday to resolve the conflicts. Despite that it is finished. |
ok, I can make resolve conflicts when I have free time. Is there any necessary js changes I need to make? (to test the feature) |
23/resumable.jsEnable You can find a detailed description about the property here. The point is, it will send a blueimp/jQuery-File-Upload
A simmilar example can be found here, the difference is you have pass the size of the file, because it is used by the handler to create a unique filename and also the size property is in the base response not under a file property. simple-uploader/UploaderThis is really simmilar to danialfarid/ng-file-uploadIt has a Same thing applies here as on
|
# Conflicts: # src/Handler/AbstractHandler.php # src/Handler/HandlerFactory.php # src/Receiver/FileReceiver.php # src/Save/AbstractSave.php # src/Save/ParallelSave.php
Fix fake file creation in test
Added test for getting the right handler from specific factories. Fixed factories accordingly.
Fixed ServiceProviderMockTest
The way I implemented the HandlerFactory isn't the best. I'll think about a better way. If you have an idea or suggestion I would appreciate it. |
Hi! I'm very interested in this functionality. Are there any news about this merge request? |
I'm also interested in this feature. |
@rluders I made a temporary solution that is working with no issues: |
Hi @nerg4l, should I find the time to check your feature? Did you finally use it in production? |
This implementation is very hacky and I decided to ditch it. With the current logic of the request handling it is really hard to distinguish between the frontend libraries when the norm of this library is to rely on the parameters/headers. I started working on a different implementation to make it simpler with using drivers. My current work is available here: https://github.com/LaraCrafts/laravel-chunk-uploader |
I see you improved the ideas -- the separation between handle / saver is not ideal I would definitely used different approach now. It could get a rewrite but to late know :) |
This resolves #10
I welcome any recommendation about my code.