Skip to content

Commit bb06ae2

Browse files
pichillilorenzopichillilorenzo
committed
Fixed NameError: global name 'subprocess' is not defined on /src/libs/terminal.py - Windows OS, Fixed NoneType error on self.completions.append(completion) in /src/listeners/completion.py
1 parent 5225e1c commit bb06ae2

File tree

5 files changed

+123
-4
lines changed

5 files changed

+123
-4
lines changed

‎changelog/0.16.0.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ v0.16.0
1818
- Added initial support for Vue.js (see https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki/Example-Vue.js-project)
1919
- Improved extract method feature
2020
- Improved completions detection from default_autocomplete.json
21-
- Added flow warnings
21+
- Added Flow warnings
2222
- Improved unused variable feature
2323

2424
## Misc

‎changelog/0.16.1.txt

Lines changed: 118 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,118 @@
1+
v0.16.1
2+
3+
# Fixes
4+
5+
- Fixed NameError: global name 'subprocess' is not defined on /src/libs/terminal.py - Windows OS
6+
- Fixed NoneType error on self.completions.append(completion) in /src/listeners/completion.py
7+
8+
9+
v0.16.0
10+
11+
## Fixes
12+
13+
- Fixed jsdoc generate command
14+
- Fixed error on refactor safe commands when the file name is empty
15+
- Fixed export refactor feature preview
16+
- Fixed some popup colors with different theme color scheme
17+
- Fixed completions and hover_description that starts with "$"
18+
- Fixed issue #36, keymap of next flow error feature changed from "super+alt+c" to "super+alt+b"
19+
20+
## Improvements
21+
22+
- Complete code plugin refactoring
23+
- Improved completions performance using 'flow ide' command
24+
- Added "code screenshot" feature using [carbon](https://carbon.now.sh/)
25+
- updated flow-bin to 0.67.1
26+
- Added initial support for Vue.js (see https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki/Example-Vue.js-project)
27+
- Improved extract method feature
28+
- Improved completions detection from default_autocomplete.json
29+
- Added Flow warnings
30+
- Improved unused variable feature
31+
32+
## Misc
33+
- Changed gutter color (using other available sublime scopes) for errors and unused variable features.
34+
35+
=================================================================
36+
** THIS PLUGIN IS IN BETA! Thanks for your support in advance! **
37+
=================================================================
38+
39+
If you like it, remember to star it ⭐ on GitHub: https://github.com/pichillilorenzo/JavaScriptEnhancements
40+
41+
** USAGE **
42+
===========
43+
44+
See how it works on the Wiki: 👉👉 https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki 👈👈
45+
46+
47+
** WHAT IS THIS? **
48+
===================
49+
50+
This plugin uses Flow (javascript static type checker from Facebook) under the hood.
51+
52+
It offers better javascript autocomplete and a lot of features about creating,
53+
developing and managing javascript projects, such as:
54+
55+
- Cordova projects (run cordova emulate, build, compile, serve, etc. directly from Sublime Text!)
56+
- Ionic v1 and v2 (it includes also v3) projects (same as Cordova projects!)
57+
- Angular v1 and v2 (it includes also v4 and v5) projects
58+
- Vue projects (only about the creation at this moment, see https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki/Example-Vue.js-project)
59+
- React projects (only about the creation at this moment)
60+
- React Native projects (only about the creation at this moment. I will add also NativeScript support)
61+
- Express projects (only about the creation at this moment)
62+
- Yeoman generators
63+
- Local bookmarks project
64+
- JavaScript real-time errors
65+
- Code Refactoring
66+
- etc.
67+
68+
You could use it also in existing projects (see the Wiki - https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki/Using-it-with-an-existing-project)!
69+
70+
It turns Sublime Text into a JavaScript IDE like!
71+
72+
This project is based on my other Sublime Text plugin JavaScript Completions (https://github.com/pichillilorenzo/JavaScript-Completions)
73+
74+
** NOTE **
75+
If you want use this plugin, you may want uninstall/disable the JavaScript Completions plugin, if installed.
76+
77+
** OS SUPPORTED **
78+
==================
79+
80+
👉 Linux (64-bit)
81+
👉 Mac OS X
82+
👉 Windows (64-bit): released without the use of TerminalView plugin. For each feature (like also creating a project) will be used the cmd.exe shell (so during the creation of a project don't close it until it finishes!). Unfortunately the TerminalView plugin supports only Linux-based OS 😞. Has someone any advice or idea about that? Is there something similar to the TerminalView plugin for Windows?? Thanks!
83+
84+
❗❗ Dependencies ❗❗
85+
=======================
86+
87+
In order to work properly, this plugin has some dependencies:
88+
89+
👉 Sublime Text 3 (build 3124 or newer)
90+
👉 Node.js and npm (https://nodejs.org or nvm (https://github.com/creationix/nvm))
91+
👉 TerminalView (only for Linux and Mac OS X) sublime text plugin (https://github.com/Wramberg/TerminalView)
92+
93+
Not required, but useful for typescript files (Flow wont work on this type of files):
94+
95+
👉 TypeScript sublime text plugin (https://github.com/Microsoft/TypeScript-Sublime-Plugin)
96+
97+
** Flow Requirements **
98+
=======================
99+
100+
It use [Flow](https://github.com/facebook/flow) for type checking and auto-completions.
101+
102+
👉 Mac OS X
103+
👉 Linux (64-bit)
104+
👉 Windows (64-bit)
105+
106+
Email me for any questions or doubts about this new project on: pichillilorenzo@gmail.com
107+
108+
** Donation **
109+
==============
110+
111+
If this project help you reduce time to develop and also you like it, please support it with a donation 😄👍. Thanks!
112+
113+
Open Collective: https://opencollective.com/javascriptenhancements/donate
114+
PayPal: https://www.paypal.me/LorenzoPichilli
115+
116+
Thanks anyway for your support! 😄😄
117+
118+
MIT License

‎messages.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,6 @@
1919
"0.13.16": "changelog/0.13.16.txt",
2020
"0.13.17": "changelog/0.13.17.txt",
2121
"0.15.0": "changelog/0.15.0.txt",
22-
"0.16.0": "changelog/0.16.0.txt"
22+
"0.16.0": "changelog/0.16.0.txt",
23+
"0.16.1": "changelog/0.16.1.txt"
2324
}

‎src/libs/terminal.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import sublime, sublime_plugin
2-
import shlex, json, os
2+
import shlex, json, os, subprocess
33
from os.path import expanduser
44

55
class Terminal():

‎src/listeners/completion.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def load_default_autocomplete(view, comps_to_campare, prefix, location, isHover
4747
return final_completions
4848

4949
class JavascriptEnhancementsCompletionsEventListener(sublime_plugin.EventListener):
50-
completions = None
50+
completions = list()
5151
completions_ready = False
5252
searching = False
5353
modified = False

0 commit comments

Comments
 (0)