Added Windows Support, bug fixes for create project feature

Author: pichillilorenzo

Default.sublime-keymap

@@ -25,7 +25,7 @@
     "keys": ["ctrl+alt+s"],
     "command": "show_hint_parameters"
   },
-  {"keys": ["tab"], "command": "window_keypress", "args": {"key": "tab"}, "context": [{"key": "setting.javascript_enhancements_window"}]},
-  {"keys": ["shift+tab"], "command": "window_keypress", "args": {"key": "shift+tab"}, "context": [{"key": "setting.javascript_enhancements_window"}]},
-  {"keys": ["ctrl+alt+a"], "command": "window_keypress", "args": {"key": "ctrl+alt+a"}, "context": [{"key": "setting.javascript_enhancements_window"}]}
+  {"keys": ["tab"], "command": "window_view_keypress", "args": {"key": "tab"}, "context": [{"key": "setting.javascript_enhancements_window"}]},
+  {"keys": ["shift+tab"], "command": "window_view_keypress", "args": {"key": "shift+tab"}, "context": [{"key": "setting.javascript_enhancements_window"}]},
+  {"keys": ["ctrl+alt+a"], "command": "window_view_keypress", "args": {"key": "ctrl+alt+a"}, "context": [{"key": "setting.javascript_enhancements_window"}]}
 ]

README.md

@@ -20,7 +20,7 @@ It offers better **javascript autocomplete** and also a lot of features about cr
 - Yeoman generators
 - Local bookmarks project
 - JavaScript real-time errors
-- etc.
+- etc. (I will add also **React Native** and **NativeScript** support)
 
 You could use it also in **existing projects** (see the [Wiki](https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki/Using-it-with-an-existing-project))!
 
@@ -35,18 +35,15 @@ If you want use this plugin, you may want **uninstall/disable** the **JavaScript
 
 - Linux (64-bit)
 - Mac OS X
-
-### For Windows users
-
-For Windows support I will create a **degraded** mode without the use of **[TerminalView](https://github.com/Wramberg/TerminalView)** plugin these days, so **WATCH** the repository. Unfortunately the TerminalView plugin supports only **Linux-based OS** 😞 . Has someone any advice or idea about that? Is there something similar to the TerminalView plugin for Windows?? Thanks!
+- Windows (64-bit): released without the use of [TerminalView](https://github.com/Wramberg/TerminalView) plugin. For each feature (like also creating a project) will be used the `cmd.exe` shell (so during the creation of a project **don't close it** until it finishes!). Unfortunately the TerminalView plugin supports only **Linux-based OS** 😞 . Has someone any advice or idea about that? Is there something similar to the TerminalView plugin for Windows?? Thanks!
 
 ## Dependencies
 
 In order to work properly, this plugin has some dependencies:
 
 - **Sublime Text 3** (build **3124** or newer)
 - **Node.js** and **npm** ([nodejs.org](https://nodejs.org) or [nvm](https://github.com/creationix/nvm))
-- **TerminalView** sublime text plugin ([TerminalView](https://github.com/Wramberg/TerminalView)) 
+- **TerminalView** (only for _Linux_ and _Mac OS X_) sublime text plugin ([TerminalView](https://github.com/Wramberg/TerminalView)) 
 
 **Not required**, but **useful** for typescript files (Flow wont work on this type of files):
 
@@ -91,7 +88,7 @@ If this doesn't work too, then you could try to add the custom path that contain
 }
 ```
 
-**REMEMBER** to add `:` at the begin of the `PATH` value!! Like I already said, it uses the same syntax for the $PATH environment variable.
+For _Linux-based OS_ **REMEMBER** to add `:` (for _Windows OS_ **REMEMBER** to add `;`) at the begin of the `PATH` value!! Like I already said, it uses the same syntax for the $PATH environment variable.
 
 ## Usage
 

_generated_2018_01_08_at_03_35_58.py renamed to _generated_2018_01_08_at_23_15_43.py

@@ -0,0 +1,84 @@
+v0.11.00
+
+## Fixes
+
+- some bug fixes for create project feature
+
+## Improvements
+
+- Added support for Windows without TermivalView plugin but using the cmd.exe shell
+
+
+=================================================================
+** THIS PLUGIN IS IN BETA! Thanks for your support in advance! **
+=================================================================
+
+If you like it, remember to star it ⭐ on GitHub: https://github.com/pichillilorenzo/JavaScriptEnhancements
+
+** USAGE **
+===========
+
+See how it works on the Wiki: 👉👉 https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki 👈👈
+
+
+** WHAT IS THIS? **
+===================
+
+This plugin uses Flow (javascript static type checker from Facebook) under the hood.
+
+It offers better javascript autocomplete and a lot of features about creating, 
+developing and managing javascript projects, such as:
+
+- Cordova projects (run cordova emulate, build, compile, serve, etc. directly from Sublime Text!)
+- Ionic v1 and v2 projects (same as Cordova projects!)
+- Angular v1 and v2 projects
+- React projects
+- Express projects
+- Yeoman generators
+- Local bookmarks project
+- JavaScript real-time errors
+- etc. (I will add also React Native and NativeScript support)
+
+You could use it also in existing projects (see the Wiki - https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki/Using-it-with-an-existing-project)!
+
+It turns Sublime Text into a JavaScript IDE like!
+
+This project is based on my other Sublime Text plugin JavaScript Completions (https://github.com/pichillilorenzo/JavaScript-Completions)
+
+** NOTE **
+If you want use this plugin, you may want uninstall/disable the JavaScript Completions plugin, if installed.
+
+** OS SUPPORTED NOW **
+======================
+
+👉 Linux (64-bit)
+👉 Mac OS X 
+👉 Windows (64-bit): released without the use of TerminalView plugin. For each feature (like also creating a project) will be used the cmd.exe shell (so during the creation of a project don't close it until it finishes!). Unfortunately the TerminalView plugin supports only Linux-based OS 😞. Has someone any advice or idea about that? Is there something similar to the TerminalView plugin for Windows?? Thanks!
+
+❗❗ Dependencies ❗❗
+=======================
+
+In order to work properly, this plugin has some dependencies:
+
+👉 Sublime Text 3 (build 3124 or newer)
+👉 Node.js and npm (https://nodejs.org or nvm (https://github.com/creationix/nvm))
+👉 TerminalView (only for Linux and Mac OS X) sublime text plugin (https://github.com/Wramberg/TerminalView)
+
+Not required, but useful for typescript files (Flow wont work on this type of files):
+
+👉 TypeScript sublime text plugin (https://github.com/Microsoft/TypeScript-Sublime-Plugin) 
+
+** Flow Requirements **
+=======================
+
+It use [Flow](https://github.com/facebook/flow) for type checking and auto-completions.
+
+👉 Mac OS X
+👉 Linux (64-bit)
+👉 Windows (64-bit)
+
+Email me for any questions or doubts about this new project on: pichillilorenzo@gmail.com
+
+Thanks for your support! 😄😄
+
+MIT License

changelog/0.11.00.txt

@@ -26,7 +26,7 @@ developing and managing javascript projects, such as:
 - Yeoman generators
 - Local bookmarks project
 - JavaScript real-time errors
-- etc.
+- etc. (I will add also React Native and NativeScript support)
 
 You could use it also in existing projects (see the Wiki - https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki)!
 
@@ -42,10 +42,7 @@ If you want use this plugin, you may want uninstall/disable the JavaScript Compl
 
 👉 Linux (64-bit)
 👉 Mac OS X 
-
-### For Windows users
-
-For Windows support I will create a "degraded" mode without the use of TerminalView plugin these days, so WATCH the repository. Unfortunately the TerminalView plugin supports only Linux-based OS 😞 . Has someone any advice or idea about that? Is there something similar to the TerminalView plugin for Windows?? Thanks!
+👉 Windows (64-bit): released without the use of TerminalView plugin. For each feature (like also creating a project) will be used the cmd.exe shell (so during the creation of a project don't close it until it finishes!). Unfortunately the TerminalView plugin supports only Linux-based OS 😞. Has someone any advice or idea about that? Is there something similar to the TerminalView plugin for Windows?? Thanks!
 
 ❗❗ Dependencies ❗❗
 =======================
@@ -54,7 +51,7 @@ In order to work properly, this plugin has some dependencies:
 
 👉 Sublime Text 3 (build 3124 or newer)
 👉 Node.js and npm (https://nodejs.org or nvm (https://github.com/creationix/nvm))
-👉 TerminalView sublime text plugin (https://github.com/Wramberg/TerminalView)
+👉 TerminalView (only for Linux and Mac OS X) sublime text plugin (https://github.com/Wramberg/TerminalView)
 
 Not required, but useful for typescript files (Flow wont work on this type of files):
 

changelog/install.txt

@@ -24,7 +24,7 @@ def apply(hook_name, value='', *args, **kwargs) :
         #value = hook["hook_func"](*args, **kwargs)
         #args = (value,) + args[1:]
 
-    return value
+    #return value
 
   @staticmethod
   def count(hook_name) :

helper/Hook.py

@@ -15,20 +15,14 @@ def __init__(self, cmd="", title="", cwd="", syntax=None, keep_open=False, windo
     self.cwd = cwd or os.path.expanduser("~")
     self.syntax = syntax
     self.keep_open = keep_open
-    self.window = window
+    self.window = window or sublime.active_window()
 
   def run(self, cmd_args):
     if sublime.platform() != "windows": 
       view = self.window.new_file() 
       view.run_command('terminal_view_activate', args={"cmd": self.cmd, "title": self.title, "cwd": self.cwd, "syntax": self.syntax, "keep_open": self.keep_open} )
       self.window.run_command("terminal_view_send_string", args={"string": " ".join(cmd_args) + "\n"})
     else:
-      print([self.cmd] + 
-        ( ["-NoExit", "-Command"] if self.cmd.startswith("powershell") else ["/K"] )
-        + ( ["$Host.UI.RawUI.WindowTitle", "=", self.title] if self.cmd.startswith("powershell") else ["title", self.title] ) 
-        + ( [";", "CD", self.cwd] if self.cmd.startswith("powershell") else ["&&", "CD", self.cwd] ) 
-        + ( [";"] if self.cmd.startswith("powershell") else ["&&"] ) 
-        + cmd_args )
       subprocess.Popen( [self.cmd] + 
         ( ["-NoExit", "-Command"] if self.cmd.startswith("powershell") else ["/K"] )
         + ( ["$Host.UI.RawUI.WindowTitle", "=", self.title] if self.cmd.startswith("powershell") else ["title", self.title] ) 

helper/Terminal.py

@@ -7,7 +7,7 @@ def __init__(self, title="WindowView", window=None, view=None):
     self.view.set_name(title)
     self.view.set_read_only(True)
     self.view.set_scratch(True)
-    self.view.settings().set("javascript_enhancements_window", True)
+    self.view.settings().set("javascript_enhancements_window_view", True)
     self.view.settings().set("gutter", False)
     self.view.settings().set("highlight_line", False)
     self.view.settings().set("auto_complete_commit_on_tab", False)
@@ -23,10 +23,10 @@ def __init__(self, title="WindowView", window=None, view=None):
     self.region_ids = []
     self.region_input_ids = []
 
-    Hook.add("javascript_enhancements_window_close_"+str(self.view.id()), self.destroy)
+    Hook.add("javascript_enhancements_window_view_close_"+str(self.view.id()), self.destroy)
 
   def __del__(self):
-    Hook.removeAllHook("javascript_enhancements_window_close_"+str(self.view.id()))
+    Hook.removeAllHook("javascript_enhancements_window_view_close_"+str(self.view.id()))
     for event in self.events.keys():
       for eventRegionKey in self.events[event].keys():
         for callback in self.events[event][eventRegionKey].keys():
@@ -100,7 +100,6 @@ def getInputs(self):
 
   def replaceById(self, replace_region_id, text, key="", scope="", icon="", flags=sublime.HIDDEN, region_id="", padding=0, display_block=False, insert_point=None, replace_points=[]):
 
-    print(self.view.get_regions("input.javascriptenhancements.input"))
     region = self.view.get_regions(replace_region_id)
     if region:
       region = region[0]
@@ -111,9 +110,6 @@ def replaceById(self, replace_region_id, text, key="", scope="", icon="", flags=
 
     self.add(text, key=key, scope=scope, icon=icon, flags=flags, region_id=region_id, padding=padding, display_block=display_block, insert_point=insert_point, replace_points=[region.begin(), region.end()])
 
-    print(region)
-    print(self.view.get_regions("input.javascriptenhancements.input"))
-
   def removeById(self, region_id):
     self.view.erase_regions(region_id)
 
@@ -255,11 +251,11 @@ def run(self, edit, **args):
       if "region_id" in args and args.get("region_id"):
         view.add_regions(args.get("region_id"), [region], scope, icon, flags)
 
-class windowKeypressCommand(sublime_plugin.TextCommand):
+class windowViewKeypressCommand(sublime_plugin.TextCommand):
   def run(self, edit, **args):
     view = self.view
 
-    if view.settings().get("javascript_enhancements_window"):
+    if view.settings().get("javascript_enhancements_window_view"):
       key = args.get("key")
 
       if key == "tab" or key =="shift+tab":
@@ -287,10 +283,10 @@ def run(self, edit, **args):
             view.sel().clear()
             view.sel().add(sublime.Region(region.begin()+1, region.end()-1))
 
-class windowEventListener(sublime_plugin.EventListener):
+class windowViewEventListener(sublime_plugin.EventListener):
 
   def on_modified_async(self, view):
-    if view.settings().get("javascript_enhancements_window"):
+    if view.settings().get("javascript_enhancements_window_view"):
 
       for region in view.get_regions("input.javascriptenhancements.input"):
 
@@ -327,7 +323,7 @@ def on_modified_async(self, view):
     return
 
   def on_selection_modified_async(self, view):
-    if view.settings().get("javascript_enhancements_window"):
+    if view.settings().get("javascript_enhancements_window_view"):
 
       for region in view.get_regions("input.javascriptenhancements.input"):
         if view.sel()[0].begin() >= region.begin() + 1 and view.sel()[0].end() <= region.end() - 1:
@@ -346,9 +342,9 @@ def on_selection_modified_async(self, view):
       view.set_read_only(True)
 
   def on_text_command(self, view, command_name, args):
-    if view.settings().get("javascript_enhancements_window"):
+    if view.settings().get("javascript_enhancements_window_view"):
       Hook.apply(command_name, view, args)
 
   def on_close(self, view):
-    if view.settings().get("javascript_enhancements_window"):
-      Hook.apply("javascript_enhancements_window_close_"+str(view.id()))
+    if view.settings().get("javascript_enhancements_window_view"):
+      Hook.apply("javascript_enhancements_window_view_close_"+str(view.id()))

helper/WindowView.py

@@ -24,15 +24,18 @@ def donwload_can_i_use_json_data() :
   if Util.download_and_save(url_can_i_use_json_data, path_to_test_can_i_use_data) :
     if os.path.isfile(path_to_can_i_use_data) :
       if not Util.checksum_sha1_equalcompare(path_to_can_i_use_data, path_to_test_can_i_use_data) :
-        with open(path_to_test_can_i_use_data) as json_file:    
-          try :
-            can_i_use_file = json.load(json_file)
-            if os.path.isfile(path_to_can_i_use_data) :
-              os.remove(path_to_can_i_use_data)
-            os.rename(path_to_test_can_i_use_data, path_to_can_i_use_data)
-          except Exception as e :
-            print("Error: "+traceback.format_exc())
-            sublime.active_window().status_message("Can't use new \"Can I use\" json data from: https://raw.githubusercontent.com/Fyrd/caniuse/master/data.json")
+        json_file = open(path_to_test_can_i_use_data) 
+        try :
+          can_i_use_file = json.load(json_file)
+          if os.path.isfile(path_to_can_i_use_data) :
+            os.remove(path_to_can_i_use_data)
+          json_file.close()
+          os.rename(path_to_test_can_i_use_data, path_to_can_i_use_data)
+        except Exception as e :
+          print("Error: "+traceback.format_exc())
+          sublime.active_window().status_message("Can't use new \"Can I use\" json data from: https://raw.githubusercontent.com/Fyrd/caniuse/master/data.json")
+        if not json_file.closed:
+          json_file.close()
       if os.path.isfile(path_to_test_can_i_use_data) :
         os.remove(path_to_test_can_i_use_data)
     else :

helper/can_i_use/can_i_use_command.py

@@ -233,7 +233,7 @@ def execute(self, command, command_args, chdir="", wait_terminate=True, func_std
     if sublime.platform() == 'windows':
       args = [self.cli_path, command] + command_args
     else :
-      args = [self.node_js_path, self.cli_path, command] + command_args
+      args = [self.cli_path, command] + command_args
 
     return Util.execute(args[0], args[1:], chdir=chdir, wait_terminate=wait_terminate, func_stdout=func_stdout, args_func_stdout=args_func_stdout)
 

helper/node/main.py

@@ -19,6 +19,8 @@
 
 BOOKMARKS_FOLDER = os.path.join(HELPER_FOLDER, 'bookmarks')
 
+WINDOWS_BATCH_FOLDER = os.path.join(PACKAGE_PATH, 'windows_batch')
+
 platform_switcher = {"osx": "OSX", "linux": "Linux", "windows": "Windows"}
 os_switcher = {"osx": "darwin", "linux": "linux", "windows": "win"}
 PLATFORM = platform_switcher.get(sublime.platform())
@@ -90,6 +92,7 @@ def init(self):
         if os.path.exists(node_modules_path):
           shutil.rmtree(node_modules_path)
         sublime.error_message("Error during installation: can't install npm dependencies for JavaScript Enhancements plugin.\n\nThe error COULD be caused by the npm permission access (EACCES error), so in this case you need to repair/install node.js and npm in a way that doesn't require \"sudo\" command.\n\nFor example you could use a Node Version Manager, such as \"nvm\" or \"nodenv\".\n\nTry to run \"npm install\" inside the package of this plugin to see what you get.")
+        return
     # else:
     #   result = npm.update_all()
     #   if not result[0]: 
@@ -124,13 +127,14 @@ def start():
     sublime.error_message("Your architecture is not supported by this plugin. This plugin supports only 64bit architectures.")
     return
 
-  # try:
-  #   sys.modules["TerminalView"]
-  # except Exception as err:
-  #   response = sublime.yes_no_cancel_dialog("TerminalView plugin is missing. TerminalView is required to be able to use \"JavaScript Enhancements\" plugin.\n\nDo you want open the github repo of it?", "Yes, open it", "No")
-  #   if response == sublime.DIALOG_YES:
-  #     sublime.active_window().run_command("open_url", args={"url": "https://github.com/Wramberg/TerminalView"})
-  #   return
+  if sublime.platform() != 'windows':
+    try:
+      sys.modules["TerminalView"]
+    except Exception as err:
+      response = sublime.yes_no_cancel_dialog("TerminalView plugin is missing. TerminalView is required to be able to use \"JavaScript Enhancements\" plugin.\n\nDo you want open the github repo of it?", "Yes, open it", "No")
+      if response == sublime.DIALOG_YES:
+        sublime.active_window().run_command("open_url", args={"url": "https://github.com/Wramberg/TerminalView"})
+      return
 
   try:
     sys.modules["JavaScript Completions"]
@@ -166,7 +170,7 @@ def start():
   mainPlugin.init()
 
 def plugin_loaded():
-
+  
   if int(sublime.version()) >= 3124 :
     sublime.set_timeout_async(start, 1000)
   else:

make/_init.py

@@ -6,5 +6,6 @@
   "0.1.11": "changelog/0.1.11.txt",
   "0.1.12": "changelog/0.1.12.txt",
   "0.1.13": "changelog/0.1.13.txt",
-  "0.1.14": "changelog/0.1.14.txt"
+  "0.1.14": "changelog/0.1.14.txt",
+  "0.11.00": "changelog/0.11.00.txt"
 }