FinalClassRule now fixable

Author: ondrejmirtes

build/PHPStan/Build/FinalClassRule.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Build;
 
+use PhpParser\Modifiers;
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
 use PHPStan\File\FileHelper;
@@ -23,7 +24,7 @@
 final class FinalClassRule implements Rule
 {
 
-	public function __construct(private FileHelper $fileHelper)
+	public function __construct(private FileHelper $fileHelper, private bool $skipTests = true)
 	{
 	}
 
@@ -58,16 +59,25 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		if (str_starts_with($this->fileHelper->normalizePath($scope->getFile()), $this->fileHelper->normalizePath(dirname(__DIR__, 3) . '/tests'))) {
+		if ($this->skipTests && str_starts_with($this->fileHelper->normalizePath($scope->getFile()), $this->fileHelper->normalizePath(dirname(__DIR__, 3) . '/tests'))) {
 			return [];
 		}
 
+		$errorBuilder = RuleErrorBuilder::message(
+			sprintf('Class %s must be abstract or final.', $classReflection->getDisplayName()),
+		)->identifier('phpstan.finalClass');
+
+		$originalNode = $node->getOriginalNode();
+		if ($originalNode instanceof Node\Stmt\Class_ && $originalNode->name !== null) {
+			$errorBuilder->fixNode($originalNode, static function ($classNode) {
+				$classNode->flags |= Modifiers::FINAL;
+
+				return $classNode;
+			});
+		}
+
 		return [
-			RuleErrorBuilder::message(
-				sprintf('Class %s must be abstract or final.', $classReflection->getDisplayName()),
-			)
-				->identifier('phpstan.finalClass')
-				->build(),
+			$errorBuilder->build(),
 		];
 	}
 

tests/PHPStan/Build/FinalClassRuleTest.php

@@ -0,0 +1,35 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Build;
+
+use PHPStan\File\FileHelper;
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+
+/**
+ * @extends RuleTestCase<FinalClassRule>
+ */
+class FinalClassRuleTest extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new FinalClassRule(self::getContainer()->getByType(FileHelper::class), skipTests: false);
+	}
+
+	public function testRule(): void
+	{
+		$this->analyse([__DIR__ . '/data/final-class-rule.php'], [
+			[
+				'Class FinalClassRule\Baz must be abstract or final.',
+				29,
+			],
+		]);
+	}
+
+	public function testFix(): void
+	{
+		$this->fix(__DIR__ . '/data/final-class-rule.php', __DIR__ . '/data/final-class-rule.php.fixed');
+	}
+
+}

tests/PHPStan/Build/data/final-class-rule.php

@@ -0,0 +1,32 @@
+<?php
+
+namespace FinalClassRule;
+
+interface Foo
+{
+
+}
+
+trait Bar
+{
+
+}
+
+$c = new class () {
+
+};
+
+final class FinalFoo
+{
+
+}
+
+abstract class Lorem
+{
+
+}
+
+class Baz
+{
+
+}

tests/PHPStan/Build/data/final-class-rule.php.fixed

@@ -0,0 +1,32 @@
+<?php
+
+namespace FinalClassRule;
+
+interface Foo
+{
+
+}
+
+trait Bar
+{
+
+}
+
+$c = new class () {
+
+};
+
+final class FinalFoo
+{
+
+}
+
+abstract class Lorem
+{
+
+}
+
+final class Baz
+{
+
+}