remove dead code

staabm · staabm · commit dbfc9f7d4ed0 · 2021-08-20T13:42:35.000+02:00
Call to function is_array() with array&lt;int, string&gt;&amp;nonEmpty will always evaluate to true.
diff --git a/src/Type/Php/StrSplitFunctionReturnTypeExtension.php b/src/Type/Php/StrSplitFunctionReturnTypeExtension.php
@@ -101,9 +101,6 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
 		$items = isset($encoding)
 			? mb_str_split($stringValue, $splitLength, $encoding)
 			: str_split($stringValue, $splitLength);
-		if (!is_array($items)) {
-			throw new \PHPStan\ShouldNotHappenException();
-		}
 
 		return self::createConstantArrayFrom($items, $scope);
 	}

Original file line number	Diff line number	Diff line change
`@@ -101,9 +101,6 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,`
`101`	`101`	`$items = isset($encoding)`
`102`	`102`	`? mb_str_split($stringValue, $splitLength, $encoding)`
`103`	`103`	`: str_split($stringValue, $splitLength);`
`104`		`- if (!is_array($items)) {`
`105`		`- throw new \PHPStan\ShouldNotHappenException();`
`106`		`- }`
`107`	`104`
`108`	`105`	`return self::createConstantArrayFrom($items, $scope);`
`109`	`106`	`}`