Make "required params following optional ones" ignorable

Wirone · ondrejmirtes · commit cfe73f141c34 · 2023-02-06T11:42:42.000+01:00
Such code is working as expected and PHPStan should not enforce changes there.
diff --git a/src/Rules/FunctionDefinitionCheck.php b/src/Rules/FunctionDefinitionCheck.php
@@ -373,7 +373,7 @@ private function checkRequiredParameterAfterOptional(array $parameterNodes): arr
 			}
 			$parameterName = $parameterNode->var->name;
 			if ($optionalParameter !== null && $parameterNode->default === null && !$parameterNode->variadic) {
-				$errors[] = RuleErrorBuilder::message(sprintf('Deprecated in PHP 8.0: Required parameter $%s follows optional parameter $%s.', $parameterName, $optionalParameter))->line($parameterNode->getStartLine())->nonIgnorable()->build();
+				$errors[] = RuleErrorBuilder::message(sprintf('Deprecated in PHP 8.0: Required parameter $%s follows optional parameter $%s.', $parameterName, $optionalParameter))->line($parameterNode->getStartLine())->build();
 				continue;
 			}
 			if ($parameterNode->default === null) {

Original file line number	Diff line number	Diff line change
`@@ -373,7 +373,7 @@ private function checkRequiredParameterAfterOptional(array $parameterNodes): arr`
`373`	`373`	`}`
`374`	`374`	`$parameterName = $parameterNode->var->name;`
`375`	`375`	`if ($optionalParameter !== null && $parameterNode->default === null && !$parameterNode->variadic) {`
`376`		`- $errors[] = RuleErrorBuilder::message(sprintf('Deprecated in PHP 8.0: Required parameter $%s follows optional parameter $%s.', $parameterName, $optionalParameter))->line($parameterNode->getStartLine())->nonIgnorable()->build();`
	`376`	`+ $errors[] = RuleErrorBuilder::message(sprintf('Deprecated in PHP 8.0: Required parameter $%s follows optional parameter $%s.', $parameterName, $optionalParameter))->line($parameterNode->getStartLine())->build();`
`377`	`377`	`continue;`
`378`	`378`	`}`
`379`	`379`	`if ($parameterNode->default === null) {`