Skip to content

Commit cfe73f1

Browse files
Wironeondrejmirtes
authored andcommitted
Make "required params following optional ones" ignorable
Such code is working as expected and PHPStan should not enforce changes there.
1 parent e1c8380 commit cfe73f1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Rules/FunctionDefinitionCheck.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ private function checkRequiredParameterAfterOptional(array $parameterNodes): arr
373373
}
374374
$parameterName = $parameterNode->var->name;
375375
if ($optionalParameter !== null && $parameterNode->default === null && !$parameterNode->variadic) {
376-
$errors[] = RuleErrorBuilder::message(sprintf('Deprecated in PHP 8.0: Required parameter $%s follows optional parameter $%s.', $parameterName, $optionalParameter))->line($parameterNode->getStartLine())->nonIgnorable()->build();
376+
$errors[] = RuleErrorBuilder::message(sprintf('Deprecated in PHP 8.0: Required parameter $%s follows optional parameter $%s.', $parameterName, $optionalParameter))->line($parameterNode->getStartLine())->build();
377377
continue;
378378
}
379379
if ($parameterNode->default === null) {

0 commit comments

Comments
 (0)