Move anonymous class node attribute handling into AnonymousClassVisitor

Author: tscni

src/Analyser/NodeScopeResolver.php

@@ -117,6 +117,7 @@
 use PHPStan\Node\UnreachableStatementNode;
 use PHPStan\Node\VariableAssignNode;
 use PHPStan\Node\VarTagChangedExpressionTypeNode;
+use PHPStan\Parser\AnonymousClassVisitor;
 use PHPStan\Parser\ArrowFunctionArgVisitor;
 use PHPStan\Parser\ClosureArgVisitor;
 use PHPStan\Parser\Parser;
@@ -855,7 +856,7 @@ private function processStmtNode(
 				if ($stmt->name === null) {
 					throw new ShouldNotHappenException();
 				}
-				if ($stmt->getAttribute('anonymousClass', false) === false) {
+				if ($stmt->getAttribute(AnonymousClassVisitor::ATTRIBUTE_ANONYMOUS_CLASS, false) === false) {
 					$classReflection = $this->reflectionProvider->getClass($stmt->name->toString());
 				} else {
 					$classReflection = $this->reflectionProvider->getAnonymousClassReflection($stmt, $scope);

src/Parser/AnonymousClassVisitor.php

@@ -9,6 +9,7 @@
 class AnonymousClassVisitor extends NodeVisitorAbstract
 {
 
+	public const ATTRIBUTE_ANONYMOUS_CLASS = 'anonymousClass';
 	public const ATTRIBUTE_LINE_INDEX = 'anonymousClassLineIndex';
 
 	/** @var array<int, non-empty-list<Node\Stmt\Class_>> */
@@ -26,6 +27,7 @@ public function enterNode(Node $node): ?Node
 			return null;
 		}
 
+		$node->setAttribute(self::ATTRIBUTE_ANONYMOUS_CLASS, true);
 		$this->nodesPerLine[$node->getStartLine()][] = $node;
 
 		return null;

src/Reflection/BetterReflection/BetterReflectionProvider.php

@@ -202,7 +202,6 @@ public function getAnonymousClassReflection(Node\Stmt\Class_ $classNode, Scope $
 			$scopeFile,
 		);
 		$classNode->name = new Node\Identifier($className);
-		$classNode->setAttribute('anonymousClass', true);
 
 		if (isset(self::$anonymousClasses[$className])) {
 			return self::$anonymousClasses[$className];

src/Type/FileTypeMapper.php

@@ -8,6 +8,7 @@
 use PHPStan\BetterReflection\Util\GetLastDocComment;
 use PHPStan\Broker\AnonymousClassNameHelper;
 use PHPStan\File\FileHelper;
+use PHPStan\Parser\AnonymousClassVisitor;
 use PHPStan\Parser\Parser;
 use PHPStan\PhpDoc\PhpDocNodeResolver;
 use PHPStan\PhpDoc\PhpDocStringResolver;
@@ -260,7 +261,7 @@ function (Node $node) use ($fileName, $lookForTrait, &$traitFound, $traitMethodA
 							}
 
 							$className = $this->anonymousClassNameHelper->getAnonymousClassName($node, $fileName);
-						} elseif ((bool) $node->getAttribute('anonymousClass', false)) {
+						} elseif ((bool) $node->getAttribute(AnonymousClassVisitor::ATTRIBUTE_ANONYMOUS_CLASS, false)) {
 							$className = $node->name->name;
 						} else {
 							if ($traitFound) {
@@ -451,7 +452,7 @@ function (Node $node) use ($fileName, $lookForTrait, $phpDocNodeMap, &$traitFoun
 							}
 
 							$className = $this->anonymousClassNameHelper->getAnonymousClassName($node, $fileName);
-						} elseif ((bool) $node->getAttribute('anonymousClass', false)) {
+						} elseif ((bool) $node->getAttribute(AnonymousClassVisitor::ATTRIBUTE_ANONYMOUS_CLASS, false)) {
 							$className = $node->name->name;
 						} else {
 							if ($traitFound) {