Regression tests

Closes phpstan/phpstan#2313
Closes phpstan/phpstan#11655
Closes phpstan/phpstan#2634

Author: ondrejmirtes

tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php

@@ -878,4 +878,24 @@ public function testBug11572(): void
 		]);
 	}
 
+	public function testBug2313(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-2313.php'], []);
+	}
+
+	public function testBug11655(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-11655.php'], [
+			[
+				"Offset 3 does not exist on array{string, 'x', array{string, 'x'}}.",
+				15,
+			],
+		]);
+	}
+
+	public function testBug2634(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-2634.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Arrays/data/bug-11655.php

@@ -0,0 +1,23 @@
+<?php
+
+namespace Bug11655;
+
+class Foo
+{
+	public function test(string $v): string
+	{
+		if (preg_match('~a(x)~', $v, $matches) === 1) {
+			if (preg_match('~b(x)~', $v, $matches[2]) === 1) {
+				return $matches[2][1];
+			}
+
+			if (preg_match('~c(x)~', $v, $matches[2]) === 1) {
+				return $matches[3][1];
+			}
+
+			return $matches[1];
+		}
+
+		return 'n/a';
+	}
+}

tests/PHPStan/Rules/Arrays/data/bug-2313.php

@@ -0,0 +1,22 @@
+<?php
+
+namespace Bug2313;
+
+function safe_inc(&$variable, $increment=1) {
+	if (isset($variable)) {
+		$variable += $increment;
+	} else {
+		$variable = $increment;
+	}
+	return true;
+}
+
+function (): void {
+	$data = array('apples' => array());
+
+	safe_inc($data['apples']['count']);
+	print_r($data);
+
+	safe_inc($data['apples']['count']);
+	print_r($data);
+};

tests/PHPStan/Rules/Arrays/data/bug-2634.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace Bug2634;
+
+function hi(&$thing){
+	$thing = "hi";
+}
+
+function (): void {
+	$array = [];
+
+	hi($array["hi"]);
+};