RestrictedInternalUsageHelper extraction

Author: ondrejmirtes

conf/config.neon

@@ -1002,6 +1002,9 @@ services:
 	-
 		class: PHPStan\Rules\Generics\VarianceCheck
 
+	-
+		class: PHPStan\Rules\InternalTag\RestrictedInternalUsageHelper
+
 	-
 		class: PHPStan\Rules\IssetCheck
 		arguments:

src/Rules/InternalTag/RestrictedInternalMethodUsageExtension.php

@@ -9,40 +9,33 @@
 use function array_slice;
 use function explode;
 use function sprintf;
-use function str_starts_with;
 use function strtolower;
 
 final class RestrictedInternalMethodUsageExtension implements RestrictedMethodUsageExtension
 {
 
+	public function __construct(private RestrictedInternalUsageHelper $helper)
+	{
+	}
+
 	public function isRestrictedMethodUsage(
 		ExtendedMethodReflection $methodReflection,
 		Scope $scope,
 	): ?RestrictedUsage
 	{
 		$isMethodInternal = $methodReflection->isInternal()->yes();
-		$isDeclaringClassInternal = $methodReflection->getDeclaringClass()->isInternal();
+		$declaringClass = $methodReflection->getDeclaringClass();
+		$isDeclaringClassInternal = $declaringClass->isInternal();
 		if (!$isMethodInternal && !$isDeclaringClassInternal) {
 			return null;
 		}
 
-		$currentNamespace = $scope->getNamespace();
-		$declaringClassName = $methodReflection->getDeclaringClass()->getName();
-		$namespace = array_slice(explode('\\', $declaringClassName), 0, -1)[0] ?? null;
-		if ($currentNamespace === null) {
-			return $this->buildRestrictedUsage($methodReflection, $namespace, $isMethodInternal);
-		}
-
-		$currentNamespace = explode('\\', $currentNamespace)[0];
-		if (str_starts_with($namespace . '\\', $currentNamespace . '\\')) {
+		$declaringClassName = $declaringClass->getName();
+		if (!$this->helper->shouldBeReported($scope, $declaringClassName)) {
 			return null;
 		}
 
-		return $this->buildRestrictedUsage($methodReflection, $namespace, $isMethodInternal);
-	}
-
-	private function buildRestrictedUsage(ExtendedMethodReflection $methodReflection, ?string $namespace, bool $isMethodInternal): RestrictedUsage
-	{
+		$namespace = array_slice(explode('\\', $declaringClassName), 0, -1)[0] ?? null;
 		if ($namespace === null) {
 			if (!$isMethodInternal) {
 				return RestrictedUsage::create(

src/Rules/InternalTag/RestrictedInternalUsageHelper.php

@@ -0,0 +1,26 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\InternalTag;
+
+use PHPStan\Analyser\Scope;
+use function array_slice;
+use function explode;
+use function str_starts_with;
+
+final class RestrictedInternalUsageHelper
+{
+
+	public function shouldBeReported(Scope $scope, string $name): bool
+	{
+		$currentNamespace = $scope->getNamespace();
+		$namespace = array_slice(explode('\\', $name), 0, -1)[0] ?? null;
+		if ($currentNamespace === null) {
+			return true;
+		}
+
+		$currentNamespace = explode('\\', $currentNamespace)[0];
+
+		return !str_starts_with($namespace . '\\', $currentNamespace . '\\');
+	}
+
+}