Fix test for <= PHP8.1 and lowest deps

Author: janedbal

README.md

@@ -152,12 +152,11 @@ $query->getOneOrNullResult(Query::HYDRATE_OBJECT); // User
 
 This is due to the design of the `Query` class preventing from determining the hydration mode used by these functions unless it is specified explicitly during the call.
 
-### Numeric types inferring
+### Expression types inferring
 
-By default, any expression like `MAX(e.id)` results in `int|numeric-string` as certain drivers & PHP versions do cast the result to string.
-If you are using setup that does not do that, you can disable stringification of such expressions by setting `parameters.doctrine.stringifyExpressions` to `false`.
-
-This should be accurate behaviour for [PHP 8.1.25+ with PDO driver](https://github.com/php/php-src/blob/php-8.1.25/UPGRADING#L122-L139) and disabled `PDO::ATTR_STRINGIFY_FETCHES` (which is default).
+Whether `MAX(e.id)` is fetched as `string` or `int` highly [depends on drivers, their setup and PHP version](https://github.com/janedbal/php-database-drivers-fetch-test).
+This extension copies the logic from linked analysis, autodetects your setup and provides accurate results for `pdo_mysql`, `mysqli`, `pdo_sqlite`, `sqlite3`, `pdo_pgsql` and `pgsql`.
+Any other driver will result in union with stringified version, e.g. `numeric-string|int`.
 
 ```neon
 parameters:

phpstan.neon

@@ -37,3 +37,6 @@ parameters:
 		-
 			message: '#^Call to method getProperty\(\) on an unknown class PHPStan\\BetterReflection\\Reflection\\Adapter\\ReflectionEnum\.$#'
 			path: src/Rules/Gedmo/PropertiesExtension.php
+		-
+			message: '#^Call to function method_exists\(\) with Doctrine\\DBAL\\Connection and ''getNativeConnection'' will always evaluate to true\.$#' # needed for older DBAL versions
+			path: src/Type/Doctrine/Query/QueryResultTypeWalker.php

src/Type/Doctrine/Query/QueryResultTypeWalker.php

@@ -56,6 +56,7 @@
 use function is_numeric;
 use function is_object;
 use function is_string;
+use function method_exists;
 use function serialize;
 use function sprintf;
 use function stripos;
@@ -843,28 +844,8 @@ public function walkSelectExpression($selectExpression)
 			$resultAlias = $selectExpression->fieldIdentificationVariable ?? $this->scalarResultCounter++;
 			$type = $this->unmarshalType($expr->dispatch($this));
 
-			if (class_exists(TypedExpression::class) && $expr instanceof TypedExpression) {
-				$enforcedType = $this->resolveDoctrineType($expr->getReturnType()->getName());
-				$type = TypeTraverser::map($type, static function (Type $type, callable $traverse) use ($enforcedType): Type {
-					if ($type instanceof UnionType || $type instanceof IntersectionType) {
-						return $traverse($type);
-					}
-					if ($type instanceof NullType) {
-						return $type;
-					}
-					if ($enforcedType->accepts($type, true)->yes()) {
-						return $type;
-					}
-					if ($enforcedType instanceof StringType) {
-						if ($type instanceof IntegerType || $type instanceof FloatType) {
-							return TypeCombinator::union($type->toString(), $type);
-						}
-						if ($type instanceof BooleanType) {
-							return TypeCombinator::union($type->toInteger()->toString(), $type);
-						}
-					}
-					return $enforcedType;
-				});
+			if ($expr instanceof TypedExpression) {
+				$type = $this->resolveDoctrineType($expr->getReturnType()->getName(), null, TypeCombinator::containsNull($type)); // TODO test nullability
 			} else {
 				// Expressions default to Doctrine's StringType, whose
 				// convertToPHPValue() is a no-op. So the actual type depends on
@@ -1501,7 +1482,7 @@ private function hasAggregateFunction(AST\SelectStatement $AST): bool
 	private function shouldStringifyExpressions(Type $type): TrinaryLogic
 	{
 		$driver = $this->em->getConnection()->getDriver();
-		$nativeConnection = $this->em->getConnection()->getNativeConnection();
+		$nativeConnection = $this->getNativeConnection();
 
 		if ($nativeConnection instanceof PDO) {
 			$stringifyFetches = $this->isPdoStringifyEnabled($nativeConnection);
@@ -1580,7 +1561,16 @@ private function isPdoStringifyEnabled(PDO $pdo): bool
 		try {
 			return (bool) $pdo->getAttribute(PDO::ATTR_STRINGIFY_FETCHES);
 		} catch (PDOException $e) {
-			return false; // default
+			$selectOne = $pdo->query('SELECT 1');
+			if ($selectOne === false) {
+				return false; // this should not happen, just return attribute default value
+			}
+			$one = $selectOne->fetchColumn();
+
+			// string can be returned due to old PHP used or because ATTR_STRINGIFY_FETCHES is enabled,
+			// but it should not matter as it behaves the same way
+			// (the attribute is there to maintain BC)
+			return is_string($one);
 		}
 	}
 
@@ -1589,4 +1579,22 @@ private function isPdoEmulatePreparesEnabled(PDO $pdo): bool
 		return (bool) $pdo->getAttribute(PDO::ATTR_EMULATE_PREPARES);
 	}
 
+	/**
+	 * @return object|resource|null
+	 */
+	private function getNativeConnection()
+	{
+		$connection = $this->em->getConnection();
+
+		if (method_exists($connection, 'getNativeConnection')) {
+			return $connection->getNativeConnection();
+		}
+
+		if ($connection->getWrappedConnection() instanceof PDO) {
+			return $connection->getWrappedConnection();
+		}
+
+		return null;
+	}
+
 }