QueryBuilder analysis - fixed type-specifying extension problem

Author: ondrejmirtes

src/Type/Doctrine/QueryBuilder/QueryBuilderTypeSpecifyingExtension.php

@@ -68,8 +68,13 @@ public function specifyTypes(MethodReflection $methodReflection, MethodCall $nod
 			return new SpecifiedTypes([]);
 		}
 
+		$queryBuilderNode = $node;
+		while ($queryBuilderNode instanceof MethodCall) {
+			$queryBuilderNode = $queryBuilderNode->var;
+		}
+
 		return $this->typeSpecifier->create(
-			$node->var,
+			$queryBuilderNode,
 			$calledOnType->append($node),
 			TypeSpecifierContext::createTruthy()
 		);

tests/Rules/Doctrine/ORM/QueryBuilderDqlRuleTest.php

@@ -87,6 +87,10 @@ public function testRule(): void
 				"QueryBuilder: [Syntax Error] line 0, col 80: Error: Expected =, <, <=, <>, >, >=, !=, got ')'\nDQL: SELECT e FROM PHPStan\Rules\Doctrine\ORM\MyEntity e WHERE e.id = 1 OR e.nickname) IS NULL",
 				218,
 			],
+			[
+				'QueryBuilder: [Semantical Error] line 0, col 60 near \'transient = \': Error: Class PHPStan\Rules\Doctrine\ORM\MyEntity has no field or association named transient',
+				234,
+			],
 		]);
 	}
 

tests/Rules/Doctrine/ORM/data/query-builder-dql.php

@@ -224,4 +224,24 @@ public function qbExprIsNullSyntaxError(): void
 			->getQuery();
 	}
 
+	public function weirdTypeSpecifyingExtensionProblem(): void
+	{
+		$queryBuilder = $this->entityManager->createQueryBuilder();
+		$queryBuilder->select('e')
+			->from(MyEntity::class, 'e')
+			->where('e.transient = :test');
+
+		$queryBuilder->getQuery();
+	}
+
+	public function weirdTypeSpecifyingExtensionProblemCorrect(): void
+	{
+		$queryBuilder = $this->entityManager->createQueryBuilder();
+		$queryBuilder->select('e')
+			->from(MyEntity::class, 'e')
+			->where('e.title = :test');
+
+		$queryBuilder->getQuery();
+	}
+
 }