From 118d4381e0884d5dd348c74ba529ff5581eb8d9f Mon Sep 17 00:00:00 2001 From: dantleech Date: Thu, 16 Oct 2014 07:21:43 +0200 Subject: [PATCH] Revert "Fixed parser so that square brackets count as delimiters" This reverts commit 389396bd7aa1d9cbf7d473908612a4695c7cbcaf. --- src/PHPCR/Util/QOM/Sql2Scanner.php | 2 +- src/PHPCR/Util/QOM/Sql2ToQomQueryConverter.php | 10 +++------- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/PHPCR/Util/QOM/Sql2Scanner.php b/src/PHPCR/Util/QOM/Sql2Scanner.php index 46966df..9afafe8 100644 --- a/src/PHPCR/Util/QOM/Sql2Scanner.php +++ b/src/PHPCR/Util/QOM/Sql2Scanner.php @@ -184,7 +184,7 @@ protected function tokenize(&$tokens, $token) $buffer = ''; for ($i = 0; $i < strlen($token); $i++) { $char = trim(substr($token, $i, 1)); - if (in_array($char, array('[', ']', '.', ',', '(', ')', '='))) { + if (in_array($char, array('.', ',', '(', ')', '='))) { if ($buffer !== '') { $tokens[] = $buffer; $buffer = ''; diff --git a/src/PHPCR/Util/QOM/Sql2ToQomQueryConverter.php b/src/PHPCR/Util/QOM/Sql2ToQomQueryConverter.php index 16e63dd..12311b5 100644 --- a/src/PHPCR/Util/QOM/Sql2ToQomQueryConverter.php +++ b/src/PHPCR/Util/QOM/Sql2ToQomQueryConverter.php @@ -789,10 +789,6 @@ protected function parseLiteralValue() return $this->parseCastLiteral($token); } - if ($this->scanner->tokenIs($token, 'NULL')) { - return null; - } - $quoteString = false; if (substr($token, 0, 1) === '\'') { $quoteString = "'"; @@ -939,9 +935,9 @@ private function fetchTokenWithoutBrackets() { $token = $this->scanner->fetchNextToken(); - if ($token === '[') { - $token = $this->scanner->fetchNextToken(); - $this->scanner->expectToken(']'); + if (substr($token, 0, 1) === '[' && substr($token, -1) === ']') { + // Remove brackets around the selector name + $token = substr($token, 1, -1); } return $token;