diff --git a/tests/NodeTypeManagement/NodeTypeBaseCase.php b/tests/NodeTypeManagement/NodeTypeBaseCase.php index 927020ff..1b81260e 100644 --- a/tests/NodeTypeManagement/NodeTypeBaseCase.php +++ b/tests/NodeTypeManagement/NodeTypeBaseCase.php @@ -148,6 +148,8 @@ public function testValidateCustomNodeType() $node->setProperty('phpcr:class', ['x', 'y']); $this->session->save(); + + $this->addToAssertionCount(1); } public function testRegisterNodeTypesNoUpdate() diff --git a/tests/Query/CharacterTest.php b/tests/Query/CharacterTest.php index c55c98cf..1a7f4539 100644 --- a/tests/Query/CharacterTest.php +++ b/tests/Query/CharacterTest.php @@ -120,6 +120,8 @@ public function testQueryWithColon() ', QueryInterface::JCR_SQL2 )->execute(); + + $this->addToAssertionCount(1); } public function testQueryWithAmpersand() diff --git a/tests/Writing/MixinReferenceableTest.php b/tests/Writing/MixinReferenceableTest.php index 76a12daa..747e36e3 100644 --- a/tests/Writing/MixinReferenceableTest.php +++ b/tests/Writing/MixinReferenceableTest.php @@ -219,5 +219,7 @@ public function testCreateReferenceInSingleTransaction() $child1->setProperty('someref', $child2, PropertyType::REFERENCE); $this->session->save(); + + $this->addToAssertionCount(1); } } diff --git a/tests/Writing/SetPropertyTypesTest.php b/tests/Writing/SetPropertyTypesTest.php index eff7eb54..f22a6f8b 100644 --- a/tests/Writing/SetPropertyTypesTest.php +++ b/tests/Writing/SetPropertyTypesTest.php @@ -82,7 +82,8 @@ public function testCreateValueBinaryFromStream() $oldSession = $this->session; $this->saveAndRenewSession(); // either this $oldSession->logout(); // or this should close the stream - $this->assertNotInternalType('resource', $stream, 'The responsibility for the stream goes into phpcr who must close it'); + // phpunit assertNotInternalType type still considers the closed stream a resource + $this->assertFalse(\is_resource($stream), 'The responsibility for the stream goes into phpcr who must close it'); $bin = $this->session->getProperty('/tests_general_base/numberPropertyNode/jcr:content/newBinaryStream'); $this->assertEquals(PropertyType::BINARY, $bin->getType()); @@ -102,7 +103,8 @@ public function testCreateValueBinaryFromStreamAndRead() $oldSession = $this->session; $this->saveAndRenewSession(); // either this $oldSession->logout(); // or this should close the stream - $this->assertNotInternalType('resource', $stream, 'The responsibility for the stream goes into phpcr who must close it'); + // phpunit assertNotInternalType type still considers the closed stream a resource + $this->assertFalse(\is_resource($stream), 'The responsibility for the stream goes into phpcr who must close it'); $bin = $this->session->getProperty('/tests_general_base/numberPropertyNode/jcr:content/newBinaryStream'); $this->assertEquals(PropertyType::BINARY, $bin->getType());