From a35746a98077d3416df8dc8deff2f684b5a5fd18 Mon Sep 17 00:00:00 2001 From: "Christoph M. Becker" Date: Thu, 6 Oct 2022 16:07:46 +0200 Subject: [PATCH 1/3] Auto-close FRs and PRs as not planned As it is now, FRs and PRs are closed after some time of inactivity as `completed`[1] instead of as `not_planned`. We change that, what requires us to update to actions/stale@v5. [1] --- .github/workflows/close-stale-feature-requests.yml | 3 ++- .github/workflows/close-stale-prs.yml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/close-stale-feature-requests.yml b/.github/workflows/close-stale-feature-requests.yml index 685bdced92ec3..26093b053c7a6 100644 --- a/.github/workflows/close-stale-feature-requests.yml +++ b/.github/workflows/close-stale-feature-requests.yml @@ -15,7 +15,7 @@ jobs: issues: write pull-requests: write steps: - - uses: actions/stale@v4 + - uses: actions/stale@v5 with: days-before-close: 14 days-before-stale: 90 @@ -23,6 +23,7 @@ jobs: only-issue-labels: "Status: Requires RFC,Feature" # Hack to skip PRs, unfortunately there's no option to disable PRs only-pr-labels: inexistent-label + close-issue-reason: not_planned stale-issue-message: >- There has not been any recent activity in this feature request. It will automatically be closed in 14 days if no further action is taken. Please see https://github.com/probot/stale#is-closing-stale-issues-really-a-good-idea diff --git a/.github/workflows/close-stale-prs.yml b/.github/workflows/close-stale-prs.yml index ca4317be1e0f9..d67a7ad1bfa98 100644 --- a/.github/workflows/close-stale-prs.yml +++ b/.github/workflows/close-stale-prs.yml @@ -15,7 +15,7 @@ jobs: issues: write pull-requests: write steps: - - uses: actions/stale@v4 + - uses: actions/stale@v5 with: days-before-close: 7 days-before-stale: 60 @@ -23,4 +23,5 @@ jobs: # Hack to skip issues, unfortunately there's no option to disable issues only-issue-labels: inexistent-label only-pr-labels: Waiting on Author + close-issue-reason: not_planned stale-pr-message: There has not been any recent activity in this PR. It will automatically be closed in 7 days if no further action is taken. From 3872adbe01706a2eb94c55d82897900e559c452e Mon Sep 17 00:00:00 2001 From: "Christoph M. Becker" Date: Thu, 6 Oct 2022 17:55:11 +0200 Subject: [PATCH 2/3] Sort alphabetically --- .github/workflows/close-stale-feature-requests.yml | 2 +- .github/workflows/close-stale-prs.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/close-stale-feature-requests.yml b/.github/workflows/close-stale-feature-requests.yml index 26093b053c7a6..d4d5694ab8f0f 100644 --- a/.github/workflows/close-stale-feature-requests.yml +++ b/.github/workflows/close-stale-feature-requests.yml @@ -17,13 +17,13 @@ jobs: steps: - uses: actions/stale@v5 with: + close-issue-reason: not_planned days-before-close: 14 days-before-stale: 90 exempt-all-assignees: true only-issue-labels: "Status: Requires RFC,Feature" # Hack to skip PRs, unfortunately there's no option to disable PRs only-pr-labels: inexistent-label - close-issue-reason: not_planned stale-issue-message: >- There has not been any recent activity in this feature request. It will automatically be closed in 14 days if no further action is taken. Please see https://github.com/probot/stale#is-closing-stale-issues-really-a-good-idea diff --git a/.github/workflows/close-stale-prs.yml b/.github/workflows/close-stale-prs.yml index d67a7ad1bfa98..4e734c2dcfe2f 100644 --- a/.github/workflows/close-stale-prs.yml +++ b/.github/workflows/close-stale-prs.yml @@ -17,11 +17,11 @@ jobs: steps: - uses: actions/stale@v5 with: + close-issue-reason: not_planned days-before-close: 7 days-before-stale: 60 exempt-pr-labels: RFC,Waiting on Review # Hack to skip issues, unfortunately there's no option to disable issues only-issue-labels: inexistent-label only-pr-labels: Waiting on Author - close-issue-reason: not_planned stale-pr-message: There has not been any recent activity in this PR. It will automatically be closed in 7 days if no further action is taken. From 0b8d0557d0fcc6dfbdd4d6fb4c2a1a137237cb46 Mon Sep 17 00:00:00 2001 From: "Christoph M. Becker" Date: Thu, 6 Oct 2022 18:05:40 +0200 Subject: [PATCH 3/3] Update to actions/stale@v6 This defaults to `close-issue-reason: not_planned` so we don't need to set this explicitly. --- .github/workflows/close-stale-feature-requests.yml | 3 +-- .github/workflows/close-stale-prs.yml | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/close-stale-feature-requests.yml b/.github/workflows/close-stale-feature-requests.yml index d4d5694ab8f0f..bc4df0a326ea6 100644 --- a/.github/workflows/close-stale-feature-requests.yml +++ b/.github/workflows/close-stale-feature-requests.yml @@ -15,9 +15,8 @@ jobs: issues: write pull-requests: write steps: - - uses: actions/stale@v5 + - uses: actions/stale@v6 with: - close-issue-reason: not_planned days-before-close: 14 days-before-stale: 90 exempt-all-assignees: true diff --git a/.github/workflows/close-stale-prs.yml b/.github/workflows/close-stale-prs.yml index 4e734c2dcfe2f..e870b5e3a7809 100644 --- a/.github/workflows/close-stale-prs.yml +++ b/.github/workflows/close-stale-prs.yml @@ -15,9 +15,8 @@ jobs: issues: write pull-requests: write steps: - - uses: actions/stale@v5 + - uses: actions/stale@v6 with: - close-issue-reason: not_planned days-before-close: 7 days-before-stale: 60 exempt-pr-labels: RFC,Waiting on Review