From 087223d90c055c4ddb67b265a0399d2ac1bfc7db Mon Sep 17 00:00:00 2001
From: jcm <juan.carlos.morales@tradebyte.com>
Date: Fri, 8 Jul 2022 17:44:11 +0200
Subject: [PATCH 1/4] QA - Test Cov - ext:pcntl - pcntl_signal() - max signal
 allowed

---
 ext/pcntl/tests/pcntl_signal_001.phpt | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 ext/pcntl/tests/pcntl_signal_001.phpt

diff --git a/ext/pcntl/tests/pcntl_signal_001.phpt b/ext/pcntl/tests/pcntl_signal_001.phpt
new file mode 100644
index 0000000000000..079b7452aa0e5
--- /dev/null
+++ b/ext/pcntl/tests/pcntl_signal_001.phpt
@@ -0,0 +1,14 @@
+--TEST--
+pcntl_signal() signal greater than max available.
+--EXTENSIONS--
+pcntl
+--FILE--
+<?php
+pcntl_signal(1000000, function($signo){
+    echo "signaled\n";
+});
+echo "ok\n";
+?>
+--EXPECTF--
+Fatal error: Uncaught ValueError: pcntl_signal(): Argument #1 ($signal) must be less than %d %s
+%A
\ No newline at end of file

From ab71bf93663731c62315cb4cf9de8ee571fc7443 Mon Sep 17 00:00:00 2001
From: Juan Morales <jcmargentina@gmail.com>
Date: Fri, 8 Jul 2022 19:48:05 +0200
Subject: [PATCH 2/4] Update ext/pcntl/tests/pcntl_signal_001.phpt

Add new line at the end

Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
---
 ext/pcntl/tests/pcntl_signal_001.phpt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ext/pcntl/tests/pcntl_signal_001.phpt b/ext/pcntl/tests/pcntl_signal_001.phpt
index 079b7452aa0e5..42d0ccd904723 100644
--- a/ext/pcntl/tests/pcntl_signal_001.phpt
+++ b/ext/pcntl/tests/pcntl_signal_001.phpt
@@ -11,4 +11,4 @@ echo "ok\n";
 ?>
 --EXPECTF--
 Fatal error: Uncaught ValueError: pcntl_signal(): Argument #1 ($signal) must be less than %d %s
-%A
\ No newline at end of file
+%A

From 325709f0c414c09304af939beea43154d61e77de Mon Sep 17 00:00:00 2001
From: juan-morales <jcmargentina@gmail.com>
Date: Sun, 10 Jul 2022 23:12:06 +0200
Subject: [PATCH 3/4] Use try-catch to avoid usage of EXPECTF section

---
 ext/pcntl/tests/pcntl_signal_001.phpt | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/ext/pcntl/tests/pcntl_signal_001.phpt b/ext/pcntl/tests/pcntl_signal_001.phpt
index 42d0ccd904723..1599eb1a0b79b 100644
--- a/ext/pcntl/tests/pcntl_signal_001.phpt
+++ b/ext/pcntl/tests/pcntl_signal_001.phpt
@@ -4,11 +4,13 @@ pcntl_signal() signal greater than max available.
 pcntl
 --FILE--
 <?php
-pcntl_signal(1000000, function($signo){
-    echo "signaled\n";
-});
-echo "ok\n";
+try {
+    pcntl_signal(1000000, function($signo){
+        echo "signaled\n";
+    });    
+} catch (Error $e) {
+    echo $e->getMessage();
+}
 ?>
---EXPECTF--
-Fatal error: Uncaught ValueError: pcntl_signal(): Argument #1 ($signal) must be less than %d %s
-%A
+--EXPECT--
+pcntl_signal(): Argument #1 ($signal) must be less than 65

From 0fc426ff3e07f0fe7238663a3ec414cde7403019 Mon Sep 17 00:00:00 2001
From: Juan Morales <jcmargentina@gmail.com>
Date: Mon, 11 Jul 2022 05:58:21 +0200
Subject: [PATCH 4/4] Back to EXPECTF

---
 ext/pcntl/tests/pcntl_signal_001.phpt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ext/pcntl/tests/pcntl_signal_001.phpt b/ext/pcntl/tests/pcntl_signal_001.phpt
index 1599eb1a0b79b..2f4f385553a29 100644
--- a/ext/pcntl/tests/pcntl_signal_001.phpt
+++ b/ext/pcntl/tests/pcntl_signal_001.phpt
@@ -12,5 +12,5 @@ try {
     echo $e->getMessage();
 }
 ?>
---EXPECT--
-pcntl_signal(): Argument #1 ($signal) must be less than 65
+--EXPECTF--
+pcntl_signal(): Argument #1 ($signal) must be less than %d