diff --git a/ext/spl/spl_directory.h b/ext/spl/spl_directory.h index 88fbd0f052601..e3deb81aebff3 100644 --- a/ext/spl/spl_directory.h +++ b/ext/spl/spl_directory.h @@ -136,12 +136,12 @@ static inline spl_filesystem_object* spl_filesystem_iterator_to_object(spl_files #define SPL_FILE_DIR_KEY_AS_PATHNAME 0x00000000 /* make RecursiveDirectoryTree::key() return getPathname() */ #define SPL_FILE_DIR_KEY_AS_FILENAME 0x00000100 /* make RecursiveDirectoryTree::key() return getFilename() */ -#define SPL_FILE_DIR_FOLLOW_SYMLINKS 0x00000200 /* make RecursiveDirectoryTree::hasChildren() follow symlinks */ #define SPL_FILE_DIR_KEY_MODE_MASK 0x00000F00 /* mask RecursiveDirectoryTree::key() */ #define SPL_FILE_DIR_KEY(intern,mode) ((intern->flags&SPL_FILE_DIR_KEY_MODE_MASK)==mode) #define SPL_FILE_DIR_SKIPDOTS 0x00001000 /* Tells whether it should skip dots or not */ #define SPL_FILE_DIR_UNIXPATHS 0x00002000 /* Whether to unixify path separators */ -#define SPL_FILE_DIR_OTHERS_MASK 0x00003000 /* mask used for get/setFlags */ +#define SPL_FILE_DIR_FOLLOW_SYMLINKS 0x00004000 /* make RecursiveDirectoryTree::hasChildren() follow symlinks */ +#define SPL_FILE_DIR_OTHERS_MASK 0x00007000 /* mask used for get/setFlags */ #endif /* SPL_DIRECTORY_H */ diff --git a/ext/spl/tests/RecursiveDirectoryIterator_hasChildren.phpt b/ext/spl/tests/RecursiveDirectoryIterator_hasChildren.phpt new file mode 100644 index 0000000000000..a4bad9b52d9ed --- /dev/null +++ b/ext/spl/tests/RecursiveDirectoryIterator_hasChildren.phpt @@ -0,0 +1,35 @@ +--TEST-- +SPL: RecursiveDirectoryIterator::hasChildren() follow symlinks test +--FILE-- +key()); +var_dump($it->hasChildren()); + +$it->setFlags(FilesystemIterator::SKIP_DOTS | FilesystemIterator::KEY_AS_FILENAME); + +var_dump($it->key()); +var_dump($it->hasChildren()); + +?> +--EXPECT-- +string(7) "symlink" +bool(true) +string(7) "symlink" +bool(false) +--CLEAN-- + diff --git a/ext/spl/tests/bug80724.phpt b/ext/spl/tests/bug80724.phpt new file mode 100644 index 0000000000000..7ff118e31bcb9 --- /dev/null +++ b/ext/spl/tests/bug80724.phpt @@ -0,0 +1,46 @@ +--TEST-- +Bug #80724 (FOLLOW_SYMLINKS interfering with FilesystemIterator key flags) +--FILE-- + $value) { + echo var_dump(hasSeparator($key)); + break; +} +$iterator->rewind(); +echo var_dump(hasSeparator($iterator->key())); + +$iterator->setFlags(0); +echo var_dump(hasSeparator($iterator->key())); + +$iterator->setFlags(FilesystemIterator::KEY_AS_FILENAME); +echo var_dump(hasSeparator($iterator->key())); + +$iterator2 = new FilesystemIterator(__DIR__, FilesystemIterator::FOLLOW_SYMLINKS | FilesystemIterator::KEY_AS_FILENAME); +foreach ($iterator2 as $key => $value) { + echo var_dump(hasSeparator($key)); + break; +} +$iterator2->rewind(); +echo var_dump(hasSeparator($iterator2->key())); + +$iterator2->setFlags(0); +echo var_dump(hasSeparator($iterator2->key())); + +$iterator2->setFlags(FilesystemIterator::KEY_AS_FILENAME); +echo var_dump(hasSeparator($iterator2->key())); + +function hasSeparator($key) { + return str_contains($key, __DIR__ . DIRECTORY_SEPARATOR); +} + +?> +--EXPECT-- +bool(false) +bool(false) +bool(true) +bool(false) +bool(false) +bool(false) +bool(true) +bool(false) diff --git a/ext/spl/tests/filesystemiterator_flags.phpt b/ext/spl/tests/filesystemiterator_flags.phpt index 1a8cce034e33c..b4e582b77ae12 100644 --- a/ext/spl/tests/filesystemiterator_flags.phpt +++ b/ext/spl/tests/filesystemiterator_flags.phpt @@ -34,7 +34,7 @@ function printflags($it) { 00000010 00000100 00003000 -00003FF0 +00007FF0 000000F0 00000F00 -00003000 +00007000