From c4c4b01797897a02b643937ce953ac673c1b390a Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Wed, 21 Oct 2020 11:55:03 +0200 Subject: [PATCH] Don't allow passing unknown named params to class without ctor --- Zend/tests/named_params/ctor_extra_named_args.phpt | 14 ++++++++++++++ Zend/zend_execute.c | 8 ++++++-- 2 files changed, 20 insertions(+), 2 deletions(-) create mode 100644 Zend/tests/named_params/ctor_extra_named_args.phpt diff --git a/Zend/tests/named_params/ctor_extra_named_args.phpt b/Zend/tests/named_params/ctor_extra_named_args.phpt new file mode 100644 index 0000000000000..139489c6b6e79 --- /dev/null +++ b/Zend/tests/named_params/ctor_extra_named_args.phpt @@ -0,0 +1,14 @@ +--TEST-- +Passing unknown named args to a non-existing ctor +--FILE-- +getMessage(), "\n"; +} + +?> +--EXPECT-- +Unknown named parameter $x diff --git a/Zend/zend_execute.c b/Zend/zend_execute.c index ab231f952f0ca..1cec01591e990 100644 --- a/Zend/zend_execute.c +++ b/Zend/zend_execute.c @@ -130,13 +130,12 @@ static ZEND_FUNCTION(pass) } ZEND_BEGIN_ARG_INFO_EX(zend_pass_function_arg_info, 0, 0, 0) - ZEND_ARG_VARIADIC_INFO(0, args) ZEND_END_ARG_INFO() ZEND_API const zend_internal_function zend_pass_function = { ZEND_INTERNAL_FUNCTION, /* type */ {0, 0, 0}, /* arg_flags */ - ZEND_ACC_VARIADIC, /* fn_flags */ + 0, /* fn_flags */ NULL, /* name */ NULL, /* scope */ NULL, /* prototype */ @@ -1097,6 +1096,11 @@ static zend_never_inline ZEND_ATTRIBUTE_UNUSED bool zend_verify_internal_arg_typ * trust that arginfo matches what is enforced by zend_parse_parameters. */ static zend_always_inline zend_bool zend_internal_call_should_throw(zend_function *fbc, zend_execute_data *call) { + if (fbc->internal_function.handler == ZEND_FN(pass)) { + /* Be lenient about the special pass function. */ + return 0; + } + if (fbc->common.required_num_args > ZEND_CALL_NUM_ARGS(call)) { /* Required argument not passed. */ return 1;