Add stubs for SAPIs #5295
Add stubs for SAPIs #5295
Conversation
| ZEND_ARG_INFO(0, extension_filename) | ||
| ZEND_END_ARG_INFO() | ||
| /* }}} */ | ||
|
|
||
| static const zend_function_entry additional_functions[] = { |
There was a problem hiding this comment.
Any idea what's up with these two separate function lists in this SAPI?
There was a problem hiding this comment.
huh, no idea. Although, what I can see is:
- some other SAPIs also have "additional functions"
- they all do something like this:
cgi_sapi_module.additional_functions = additional_functions;
kocsismate
force-pushed
the
sapi-stub
branch
2 times, most recently
from
93a2730 to
c8cab92
Compare
|
The apache2handler, fpm, litespeed, phpdbg parts here look fine, feel free to merge those already. I'm not entirely happy about the cli/cgi handling, and wondering how we could make this work with generated function entries. |
|
Will merge them! I was also thinking about the problem, but I wasn't able to come up with a good idea as far as I remember. :( |
For apache2handler, fpm, litespeed, phpdbg, specifically. Partially implements GH-5295
|
I rebased and merged this. It would have been nice to use generated function entries, but it's probably not worth the time to solve this in a better way (like "include" support in stubs). |
|
@nikic I do agree. Thanks for the merge! |
No description provided.