From 2e4336bf5d8b9dd56bbab772814d503d4acd8d4d Mon Sep 17 00:00:00 2001 From: vanviegen Date: Wed, 21 Dec 2016 16:18:14 +0100 Subject: [PATCH] Fix for sporadic segfault with MYSQLI_OPT_INT_AND_FLOAT_NATIVE Fixes bug #73800 --- ext/mysqlnd/mysqlnd_wireprotocol.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ext/mysqlnd/mysqlnd_wireprotocol.c b/ext/mysqlnd/mysqlnd_wireprotocol.c index 03fcad987717a..b057a44e8276f 100644 --- a/ext/mysqlnd/mysqlnd_wireprotocol.c +++ b/ext/mysqlnd/mysqlnd_wireprotocol.c @@ -1477,7 +1477,12 @@ php_mysqlnd_read_row_ex(MYSQLND_PFC * pfc, zero-length byte, don't read the body, there is no such. */ - *data_size = 0; + /* + We're allocating an extra byte, as php_mysqlnd_rowp_read_text_protocol_aux + needs to be able to append a terminating \0 for atoi/atof. + */ + *data_size = 1; + while (1) { if (FAIL == mysqlnd_read_header(pfc, vio, &header, stats, error_info)) { ret = FAIL; @@ -1526,6 +1531,7 @@ php_mysqlnd_read_row_ex(MYSQLND_PFC * pfc, pool->free_chunk(pool, *buffer); *buffer = NULL; } + *data_size--; DBG_RETURN(ret); } /* }}} */