From aa820b5f8eeed5402c706282e822391c33e96281 Mon Sep 17 00:00:00 2001
From: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
Date: Wed, 16 Apr 2025 00:23:48 +0200
Subject: [PATCH] Fix memory leak on error return of collation callback in
 pdo_sqlite

We should destroy it when it's not IS_LONG, not when it's IS_LONG.
---
 ext/pdo_sqlite/pdo_sqlite.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ext/pdo_sqlite/pdo_sqlite.c b/ext/pdo_sqlite/pdo_sqlite.c
index bc47c15a1eb5e..ff56d04049424 100644
--- a/ext/pdo_sqlite/pdo_sqlite.c
+++ b/ext/pdo_sqlite/pdo_sqlite.c
@@ -352,6 +352,7 @@ static int php_sqlite_collation_callback(void *context, int string1_len, const v
 			zend_type_error("%s(): Return value of the callback must be of type int, %s returned",
 				ZSTR_VAL(func_name), zend_zval_value_name(&retval));
 			zend_string_release(func_name);
+			zval_ptr_dtor(&retval);
 			return FAILURE;
 		}
 		if (Z_LVAL(retval) > 0) {
@@ -359,7 +360,6 @@ static int php_sqlite_collation_callback(void *context, int string1_len, const v
 		} else if (Z_LVAL(retval) < 0) {
 			ret = -1;
 		}
-		zval_ptr_dtor(&retval);
 	}
 
 	zval_ptr_dtor(&zargs[0]);