From 7e680c0d01a28801e32ddeb01068316ca687c26f Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Sun, 2 Feb 2025 16:08:57 +0100 Subject: [PATCH] Add non-NULL assertion to zend_get_gc_buffer_add_obj() This would've saved me time when fixing the nightly failure in Laravel [1]. [1] e306a2e0 --- Zend/zend_gc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Zend/zend_gc.h b/Zend/zend_gc.h index 262d656c24ea8..06f550647bd79 100644 --- a/Zend/zend_gc.h +++ b/Zend/zend_gc.h @@ -134,6 +134,8 @@ static zend_always_inline void zend_get_gc_buffer_add_zval( static zend_always_inline void zend_get_gc_buffer_add_obj( zend_get_gc_buffer *gc_buffer, zend_object *obj) { + ZEND_ASSERT(obj != NULL); + if (UNEXPECTED(gc_buffer->cur == gc_buffer->end)) { zend_get_gc_buffer_grow(gc_buffer); }