From 379117554fe3388225b1d77b688eb845fe968084 Mon Sep 17 00:00:00 2001 From: "Christoph M. Becker" Date: Sun, 15 Dec 2024 14:00:15 +0100 Subject: [PATCH] Reduce excessive stack reserve for testing in CI For some reason the stack reserve of php.exe and php-cgi.exe is very large on Windows (64MB)[1]. While this might not be bad for production purposes, it causes stack_limit_014.phpt to be unbearably slow; the test may easily run for a minute, and due to a recent `stream_select()` improvement[2], that can cause a timeout, what triggers the test to be run again. So this single test case may run for two minutes, and still might fail (happened a couple of times). Instead of skipping the test in CI, we reduce the stack reserve to 8MB, what improves the performance of this test case (and maybe others), and should still be good enough for CI. [1] [2] --- .github/scripts/windows/test_task.bat | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/scripts/windows/test_task.bat b/.github/scripts/windows/test_task.bat index ee8a5f01b2c0c..6eafcb2e69578 100644 --- a/.github/scripts/windows/test_task.bat +++ b/.github/scripts/windows/test_task.bat @@ -131,6 +131,10 @@ for %%i in (ldap) do ( del %PHP_BUILD_DIR%\php_%%i.dll ) +rem reduce excessive stack reserve for testing +editbin /stack:8388608 %PHP_BUILD_DIR%\php.exe +editbin /stack:8388608 %PHP_BUILD_DIR%\php-cgi.exe + set TEST_PHPDBG_EXECUTABLE=%PHP_BUILD_DIR%\phpdbg.exe if "%ASAN%" equ "1" set ASAN_OPTS=--asan