diff --git a/ext/dom/inner_html_mixin.c b/ext/dom/inner_html_mixin.c index 262c85411aaf2..e72b205bf4628 100644 --- a/ext/dom/inner_html_mixin.c +++ b/ext/dom/inner_html_mixin.c @@ -359,6 +359,9 @@ zend_result dom_element_inner_html_write(dom_object *obj, zval *newval) } } + ZEND_ASSERT(obj->document != NULL); + php_libxml_invalidate_node_list_cache(obj->document); + dom_remove_all_children(context_node); return php_dom_pre_insert(obj->document, fragment, context_node, NULL) ? SUCCESS : FAILURE; } diff --git a/ext/dom/tests/modern/common/innerHTML_cache_invalidation.phpt b/ext/dom/tests/modern/common/innerHTML_cache_invalidation.phpt new file mode 100644 index 0000000000000..976be202cece2 --- /dev/null +++ b/ext/dom/tests/modern/common/innerHTML_cache_invalidation.phpt @@ -0,0 +1,27 @@ +--TEST-- +$innerHTML cache invalidation +--EXTENSIONS-- +dom +--FILE-- +'); +$els = $dom->getElementsByTagName('a'); +var_dump($els[0]->tagName); + +$dom->documentElement->innerHTML = ''; + +echo $dom->saveXML(), "\n"; +var_dump($els); +var_dump($els[0]?->tagName); + +?> +--EXPECT-- +string(1) "a" + + +object(Dom\HTMLCollection)#2 (1) { + ["length"]=> + int(0) +} +NULL