diff --git a/ext/date/php_date.c b/ext/date/php_date.c index dc9eb995b8f65..1f49a7f0e0bf4 100644 --- a/ext/date/php_date.c +++ b/ext/date/php_date.c @@ -5140,6 +5140,9 @@ static void php_do_date_sunrise_sunset(INTERNAL_FUNCTION_PARAMETERS, bool calc_s if (N > 24 || N < 0) { N -= floor(N / 24) * 24; } + if (N > 24 || N < 0) { + RETURN_FALSE; + } switch (retformat) { case SUNFUNCS_RET_STRING: diff --git a/ext/date/tests/gh16454.phpt b/ext/date/tests/gh16454.phpt new file mode 100644 index 0000000000000..3d57276ddf5d3 --- /dev/null +++ b/ext/date/tests/gh16454.phpt @@ -0,0 +1,21 @@ +--TEST-- +GH-16454 (Unhandled INF in date_sunset() with tiny $utcOffset) +--FILE-- + +--EXPECTF-- +Deprecated: Function date_sunrise() is deprecated in %s on line %d +bool(false) + +Deprecated: Function date_sunrise() is deprecated in %s on line %d +bool(false) + +Deprecated: Function date_sunset() is deprecated in %s on line %d +bool(false) + +Deprecated: Function date_sunset() is deprecated in %s on line %d +bool(false)