From 50f9d37a82453801c405b57492faea3433aabc75 Mon Sep 17 00:00:00 2001 From: "Christoph M. Becker" Date: Thu, 3 Oct 2024 00:44:16 +0200 Subject: [PATCH] Fix GH-16181: phpdbg: exit in exception handler reports fatal error When running PHP code, we must not handle `UnwindExit` exceptions, but rather have to ignore them. --- sapi/phpdbg/phpdbg_prompt.c | 2 +- sapi/phpdbg/tests/gh16181.phpt | 26 ++++++++++++++++++++++++++ 2 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 sapi/phpdbg/tests/gh16181.phpt diff --git a/sapi/phpdbg/phpdbg_prompt.c b/sapi/phpdbg/phpdbg_prompt.c index 887064cf2e70b..448194f13d261 100644 --- a/sapi/phpdbg/phpdbg_prompt.c +++ b/sapi/phpdbg/phpdbg_prompt.c @@ -907,7 +907,7 @@ PHPDBG_COMMAND(run) /* {{{ */ } } zend_end_try(); - if (EG(exception)) { + if (EG(exception) && !zend_is_unwind_exit(EG(exception))) { phpdbg_handle_exception(); } } diff --git a/sapi/phpdbg/tests/gh16181.phpt b/sapi/phpdbg/tests/gh16181.phpt new file mode 100644 index 0000000000000..478bbb98ca0d9 --- /dev/null +++ b/sapi/phpdbg/tests/gh16181.phpt @@ -0,0 +1,26 @@ +--TEST-- +GH-16181 (phpdbg: exit in exception handler reports fatal error) +--PHPDBG-- +r +c +q +--FILE-- + +--EXPECTF-- +[Successful compilation of %s] +prompt> throwing exception +[Uncaught Exception in %s on line %d: oh noes] +>00008: throw new \Exception("oh noes"); + 00009: ?> + 00010: +prompt> exception caught +[Script ended normally] +prompt>