From f873b2a93784bae92729423bdc76496879187752 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20D=C3=BCsterhus?= Date: Wed, 25 Sep 2024 14:00:54 +0200 Subject: [PATCH] pdo: Use `zend_string_toupper` in pdo_stmt_describe_columns zend_string_toupper was only introduced in PHP 8.2 and thus it likely was not used here, since this code was last touched for PHP 8.0. --- ext/pdo/pdo_stmt.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/ext/pdo/pdo_stmt.c b/ext/pdo/pdo_stmt.c index 4fc95aa7d6fee..2ba34527bad84 100644 --- a/ext/pdo/pdo_stmt.c +++ b/ext/pdo/pdo_stmt.c @@ -144,15 +144,10 @@ bool pdo_stmt_describe_columns(pdo_stmt_t *stmt) /* {{{ */ stmt->columns[col].name = zend_string_tolower(orig_name); zend_string_release(orig_name); break; - case PDO_CASE_UPPER: { - stmt->columns[col].name = zend_string_separate(orig_name, 0); - char *s = ZSTR_VAL(stmt->columns[col].name); - while (*s != '\0') { - *s = toupper(*s); - s++; - } + case PDO_CASE_UPPER: + stmt->columns[col].name = zend_string_toupper(orig_name); + zend_string_release(orig_name); break; - } EMPTY_SWITCH_DEFAULT_CASE() } }