From 9e821e1661473b9fd34158dc1f13cdef5616b074 Mon Sep 17 00:00:00 2001 From: Peter Kokot Date: Thu, 18 Jul 2024 20:42:18 +0200 Subject: [PATCH 1/3] [skip ci] Sync CODEOWNERS This repeats the sync as noted in the GH-13591 and the discussion https://news-web.php.net/php.internals/124472 The CODEOWNERS file is related to the targeted branch in the pull request and not only the master branch. - CS style comments synced (80 columns length) - Added a note to change the earliest supported PHP branch and not only master branch - Synced GitHub ID's and paths across the PHP-8.2, PHP-8.3 and master branches --- .github/CODEOWNERS | 36 ++++++++++++++++++++++++++---------- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index ed1a5105db797..f9fe9c90c8ddd 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,40 +1,54 @@ -# The following volunteers have self-identified as subject matter experts -# or interested parties over a particular area of the php-src source code. -# While requesting a review from someone does not obligate that person to -# review a pull request, these reviewers might have valuable knowledge of -# the problem area and could aid in deciding whether a pull request is ready -# for merging. +# The following volunteers have self-identified as subject matter experts or +# interested parties in a particular area of the php-src source code. While +# requesting a review from someone does not obligate that person to review a +# pull request, these reviewers might have valuable knowledge of the problem +# area and could aid in deciding whether a pull request is ready for merging. +# +# When changing this file, please make sure to commit the changes to the +# earliest supported PHP branch (PHP-X.Y) and not only to the master branch. +# GitHub reads the CODEOWNERS file from the pull request's targeted branch. # # For more information, see the GitHub CODEOWNERS documentation: # https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners /.github @iluuu1994 @TimWolla /build/gen_stub.php @kocsismate -/ext/bcmath @Girgias +/ext/bcmath @Girgias @nielsdos @SakiTakamachi /ext/curl @adoy /ext/date @derickr /ext/dba @Girgias /ext/dom @nielsdos /ext/ffi @dstogov +/ext/gd @devnexen /ext/gettext @devnexen /ext/gmp @Girgias /ext/imap @Girgias /ext/intl @devnexen /ext/json @bukka /ext/libxml @nielsdos -/ext/mbstring @alexdowad +/ext/mbstring @alexdowad @youkidearitai +/ext/mysqlnd @SakiTakamachi /ext/odbc @NattyNarwhal /ext/opcache @dstogov @iluuu1994 /ext/openssl @bukka -/ext/pdo_odbc @NattyNarwhal -/ext/pdo_pgsql @devnexen +/ext/pcntl @devnexen +/ext/pdo @SakiTakamachi +/ext/pdo_dblib @SakiTakamachi +/ext/pdo_firebird @SakiTakamachi +/ext/pdo_mysql @SakiTakamachi +/ext/pdo_odbc @NattyNarwhal @SakiTakamachi +/ext/pdo_pgsql @devnexen @SakiTakamachi +/ext/pdo_sqlite @SakiTakamachi /ext/pgsql @devnexen /ext/random @TimWolla @zeriyoshi /ext/session @Girgias +/ext/simplexml @nielsdos /ext/sockets @devnexen /ext/spl @Girgias /ext/standard @bukka +/ext/xml @nielsdos /ext/xmlreader @nielsdos +/ext/xmlwriter @nielsdos /ext/xsl @nielsdos /main @bukka /sapi/fpm @bukka @@ -44,6 +58,8 @@ /Zend/zend_API.* @dstogov @iluuu1994 /Zend/zend_call_stack.* @arnaud-lb /Zend/zend_closures.* @dstogov +/Zend/zend_compile.* @iluuu1994 +/Zend/zend_enum.* @iluuu1994 /Zend/zend_execute.* @dstogov @iluuu1994 /Zend/zend_execute_API.c @dstogov @iluuu1994 /Zend/zend_gc.* @dstogov @arnaud-lb From e79aa8b6ae022b9407b77c7ca0f053f51e0853ad Mon Sep 17 00:00:00 2001 From: Peter Kokot Date: Fri, 19 Jul 2024 01:02:31 +0200 Subject: [PATCH 2/3] - Use random line length of ~76 columns - Revert "in a particular area" to "over a particular area" grammar/contextual fix - Add note how changes here should be analogous to bug fixes [skip ci] --- .github/CODEOWNERS | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index f9fe9c90c8ddd..abe684150f743 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,12 +1,14 @@ -# The following volunteers have self-identified as subject matter experts or -# interested parties in a particular area of the php-src source code. While -# requesting a review from someone does not obligate that person to review a -# pull request, these reviewers might have valuable knowledge of the problem -# area and could aid in deciding whether a pull request is ready for merging. +# The following volunteers have self-identified as subject matter experts +# or interested parties over a particular area of the php-src source code. +# While requesting a review from someone does not obligate that person to +# review a pull request, these reviewers might have valuable knowledge of +# the problem area and could aid in deciding whether a pull request is ready +# for merging. # # When changing this file, please make sure to commit the changes to the # earliest supported PHP branch (PHP-X.Y) and not only to the master branch. # GitHub reads the CODEOWNERS file from the pull request's targeted branch. +# Commit changes here like bug fixes. # # For more information, see the GitHub CODEOWNERS documentation: # https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners From d914e85dce6afe7106ea578141e56761988c62f6 Mon Sep 17 00:00:00 2001 From: Peter Kokot Date: Wed, 24 Jul 2024 00:19:52 +0200 Subject: [PATCH 3/3] [skip ci] Add link to CONTRIBUTING.md which describes which branch to target --- .github/CODEOWNERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index abe684150f743..24a656eac19e0 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -8,7 +8,8 @@ # When changing this file, please make sure to commit the changes to the # earliest supported PHP branch (PHP-X.Y) and not only to the master branch. # GitHub reads the CODEOWNERS file from the pull request's targeted branch. -# Commit changes here like bug fixes. +# Commit changes here similar to bug fixes: +# https://github.com/php/php-src/blob/master/CONTRIBUTING.md#pull-requests # # For more information, see the GitHub CODEOWNERS documentation: # https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners