From 7b29e2e466a905fa248a7afa450db71dd8077f2e Mon Sep 17 00:00:00 2001 From: Peter Kokot Date: Sun, 23 Jun 2024 22:36:29 +0200 Subject: [PATCH] Use AC_DEFINE_UNQUOTED where variables are used According to Autoconf documentation AC_DEFINE_UNQUOTED should be used, where shell variables are used in the macro arguments. https://www.gnu.org/software/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fDEFINE_005fUNQUOTED-2 This also adds simple help descriptions to these CPP macros. --- ext/dba/config.m4 | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ext/dba/config.m4 b/ext/dba/config.m4 index b9cf1d898ead9..2fda2d589d237 100644 --- a/ext/dba/config.m4 +++ b/ext/dba/config.m4 @@ -354,7 +354,8 @@ AC_DEFUN([PHP_DBA_DB_CHECK],[ ]) fi if test -n "$THIS_LIBS"; then - AC_DEFINE(DBA_DB$1, 1, [ ]) + AC_DEFINE_UNQUOTED([DBA_DB$1], [1], + [Define to 1 if Berkeley DB is compatible with version $1.]) if test -n "$THIS_INCLUDE"; then AC_DEFINE_UNQUOTED(DB$1_INCLUDE_FILE, "$THIS_INCLUDE", [ ]) fi @@ -553,7 +554,8 @@ if test "$PHP_DB1" != "no"; then DB * dbp = dbopen("", 0, 0, DB_HASH, 0); ]])],[ AC_DEFINE_UNQUOTED(DB1_INCLUDE_FILE, "$THIS_INCLUDE", [ ]) - AC_DEFINE(DBA_DB1, 1, [ ]) + AC_DEFINE([DBA_DB1], [1], + [Define to 1 if Berkeley DB is compatible with version 1.]) THIS_RESULT=yes ],[ THIS_RESULT=no