From 5c6fe6cce20c0b219ee022f6e063bc163356347d Mon Sep 17 00:00:00 2001 From: Peter Kokot Date: Thu, 23 May 2024 00:26:16 +0200 Subject: [PATCH 1/2] Check ext/pcntl required functions with for loop This omits defining redundant HAVE_ symbols since these are used unconditionally in ext/pcntl. * HAVE_FORK is defined via ext/standard/config.m4 * HAVE_SIGACTION is defined via Zend.m4 * HAVE_WAITPID symbol is removed --- ext/pcntl/config.m4 | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ext/pcntl/config.m4 b/ext/pcntl/config.m4 index 4d54d75fb0302..f781ea8b3da48 100644 --- a/ext/pcntl/config.m4 +++ b/ext/pcntl/config.m4 @@ -4,8 +4,10 @@ PHP_ARG_ENABLE([pcntl], [Enable pcntl support (CLI/CGI only)])]) if test "$PHP_PCNTL" != "no"; then - AC_CHECK_FUNCS([fork waitpid sigaction],, - [AC_MSG_ERROR([ext/pcntl: required function $ac_func() not found.])]) + for function in fork sigaction waitpid; do + AC_CHECK_FUNC([$function],, + [AC_MSG_ERROR([ext/pcntl: required function $function() not found.])]) + done AC_CHECK_FUNCS(m4_normalize([ forkx From 51afdb0469dd2e5e5a18b6b32c80b6f246b3d3be Mon Sep 17 00:00:00 2001 From: Peter Kokot Date: Tue, 4 Jun 2024 17:47:54 +0200 Subject: [PATCH 2/2] [skip ci] Update upgrading notes --- UPGRADING.INTERNALS | 1 + 1 file changed, 1 insertion(+) diff --git a/UPGRADING.INTERNALS b/UPGRADING.INTERNALS index 8f62015f733fd..95c8d580b5cd0 100644 --- a/UPGRADING.INTERNALS +++ b/UPGRADING.INTERNALS @@ -128,6 +128,7 @@ PHP 8.4 INTERNALS UPGRADE NOTES - Symbols HAVE_DLOPEN and HAVE_DLSYM have been removed. - Symbol HAVE_MYSQL has been removed. - Symbol HAVE_PDO_SQLITELIB has been removed. + - Symbol HAVE_WAITPID has been removed. - M4 macro PHP_DEFINE (atomic includes) removed (use AC_DEFINE and config.h). - M4 macro PHP_WITH_SHARED has been removed (use PHP_ARG_WITH). - M4 macro PHP_STRUCT_FLOCK has been removed (use AC_CHECK_TYPES).