From f05e06c2923e430763664147406bf969b4f7a7bd Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Sun, 7 Apr 2024 14:32:23 +0200 Subject: [PATCH] Fix persistent local flag in session url updating Short-lived regression from 5ce9687cb2bc49e5d95b1c9bda5dc7f711c3da62. I forgot to add the persistent local flag, so that means that RC_DEBUG will complain. These strings are local to the thread so we can just add the flag to silence the debug checker in this case. --- ext/standard/url_scanner_ex.re | 1 + 1 file changed, 1 insertion(+) diff --git a/ext/standard/url_scanner_ex.re b/ext/standard/url_scanner_ex.re index a4a48b6bf60ee..77b4d79793b65 100644 --- a/ext/standard/url_scanner_ex.re +++ b/ext/standard/url_scanner_ex.re @@ -140,6 +140,7 @@ static int php_ini_on_update_hosts(zend_ini_entry *entry, zend_string *new_value if (keylen > 0) { /* Note: the hash table is persistently allocated, so the strings must be too! */ tmp_key = zend_string_init(key, keylen, true); + GC_MAKE_PERSISTENT_LOCAL(tmp_key); zend_hash_add_empty_element(hosts, tmp_key); zend_string_release_ex(tmp_key, true); }