From 0f9af5d1c205bd7d94baa7424d07a1ca152f69ef Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Sun, 31 Mar 2024 14:15:59 +0200 Subject: [PATCH] Simplify always-true check in zend_generator_update_current `old_root` is dereferenced at top, so `old_root` must not be NULL, and the check doesn't actually do anything. --- Zend/zend_generators.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Zend/zend_generators.c b/Zend/zend_generators.c index 036aba09805b..3da03e55a6b2 100644 --- a/Zend/zend_generators.c +++ b/Zend/zend_generators.c @@ -579,7 +579,7 @@ ZEND_API zend_generator *zend_generator_update_current(zend_generator *generator EG(current_execute_data) = original_execute_data; - if (!((old_root ? old_root : generator)->flags & ZEND_GENERATOR_CURRENTLY_RUNNING)) { + if (!(old_root->flags & ZEND_GENERATOR_CURRENTLY_RUNNING)) { new_root->node.parent = NULL; OBJ_RELEASE(&new_root_parent->std); zend_generator_resume(generator);