From b2ad1a27e98a58a2e814d948f1083bbf1823d13c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tim=20D=C3=BCsterhus?= <tim@bastelstu.be>
Date: Tue, 9 Jan 2024 20:45:34 +0100
Subject: [PATCH] Remove ext/random backwards-compatibility headers
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When ext/random was initially added in PHP 8.2, these headers started
“forwarding” to the new ext/random/php_random.h to reduce the impact on
existing extensions.

As master already contains some breaking changes of the internal API of
ext/random and as the last PHP version without ext/random will be EOL once
master is released, it appears appropriate to drop these headers now.
---
 UPGRADING.INTERNALS        | 4 ++++
 ext/standard/php_lcg.h     | 1 -
 ext/standard/php_mt_rand.h | 1 -
 ext/standard/php_rand.h    | 1 -
 ext/standard/php_random.h  | 1 -
 5 files changed, 4 insertions(+), 4 deletions(-)
 delete mode 100644 ext/standard/php_lcg.h
 delete mode 100644 ext/standard/php_mt_rand.h
 delete mode 100644 ext/standard/php_rand.h
 delete mode 100644 ext/standard/php_random.h

diff --git a/UPGRADING.INTERNALS b/UPGRADING.INTERNALS
index c768ab1366db..513b00d19684 100644
--- a/UPGRADING.INTERNALS
+++ b/UPGRADING.INTERNALS
@@ -30,6 +30,10 @@ PHP 8.4 INTERNALS UPGRADE NOTES
   int(*)(zend_object_iterator *) to zend_result(*)(zend_object_iterator *) to
   be more in line with what callbacks are returning.
 
+* The backwards compatibility headers ext/standard/{php_lcg.h,php_mt_rand.h,
+  php_rand.h,php_random.h} have been removed. Include ext/random/php_random.h
+  directly.
+
 ========================
 2. Build system changes
 ========================
diff --git a/ext/standard/php_lcg.h b/ext/standard/php_lcg.h
deleted file mode 100644
index b86bb003d37d..000000000000
--- a/ext/standard/php_lcg.h
+++ /dev/null
@@ -1 +0,0 @@
-#include "ext/random/php_random.h"
diff --git a/ext/standard/php_mt_rand.h b/ext/standard/php_mt_rand.h
deleted file mode 100644
index b86bb003d37d..000000000000
--- a/ext/standard/php_mt_rand.h
+++ /dev/null
@@ -1 +0,0 @@
-#include "ext/random/php_random.h"
diff --git a/ext/standard/php_rand.h b/ext/standard/php_rand.h
deleted file mode 100644
index b86bb003d37d..000000000000
--- a/ext/standard/php_rand.h
+++ /dev/null
@@ -1 +0,0 @@
-#include "ext/random/php_random.h"
diff --git a/ext/standard/php_random.h b/ext/standard/php_random.h
deleted file mode 100644
index 9af3eef3fd92..000000000000
--- a/ext/standard/php_random.h
+++ /dev/null
@@ -1 +0,0 @@
-#include "ext/random/php_random.h"
\ No newline at end of file