Fix leak in gmp_pow()

nikic · nikic · commit feaabd09d092 · 2015-04-16T16:00:47.000+02:00
diff --git a/ext/gmp/gmp.c b/ext/gmp/gmp.c
@@ -1388,11 +1388,12 @@ ZEND_FUNCTION(gmp_pow)
 		RETURN_FALSE;
 	}
 
-	INIT_GMP_RETVAL(gmpnum_result);
 	if (Z_TYPE_P(base_arg) == IS_LONG && Z_LVAL_P(base_arg) >= 0) {
+		INIT_GMP_RETVAL(gmpnum_result);
 		mpz_ui_pow_ui(gmpnum_result, Z_LVAL_P(base_arg), exp);
 	} else {
 		FETCH_GMP_ZVAL(gmpnum_base, base_arg, temp_base);
+		INIT_GMP_RETVAL(gmpnum_result);
 		mpz_pow_ui(gmpnum_result, gmpnum_base, exp);
 		FREE_GMP_TEMP(temp_base);
 	}

Original file line number	Diff line number	Diff line change
`@@ -1388,11 +1388,12 @@ ZEND_FUNCTION(gmp_pow)`
`1388`	`1388`	`RETURN_FALSE;`
`1389`	`1389`	`}`
`1390`	`1390`
`1391`		`- INIT_GMP_RETVAL(gmpnum_result);`
`1392`	`1391`	`if (Z_TYPE_P(base_arg) == IS_LONG && Z_LVAL_P(base_arg) >= 0) {`
	`1392`	`+ INIT_GMP_RETVAL(gmpnum_result);`
`1393`	`1393`	`mpz_ui_pow_ui(gmpnum_result, Z_LVAL_P(base_arg), exp);`
`1394`	`1394`	`} else {`
`1395`	`1395`	`FETCH_GMP_ZVAL(gmpnum_base, base_arg, temp_base);`
	`1396`	`+ INIT_GMP_RETVAL(gmpnum_result);`
`1396`	`1397`	`mpz_pow_ui(gmpnum_result, gmpnum_base, exp);`
`1397`	`1398`	`FREE_GMP_TEMP(temp_base);`
`1398`	`1399`	`}`